Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown

Lukas Wunner
2018-01-12T15:12:08Z

On Fri, Jan 12, 2018 at 09:26:48AM -0500, Sinan Kaya wrote:
> On 1/12/2018 5:49 AM, Lukas Wunner wrote:
> I wonder if we can separate remove from shutdown and just disable the IRQs
> in shutdown case rather than turning off the slot power etc.

But don't we risk "IRQ xx: nobody cared" splats if we do that?

Not sure if just disabling the IRQ without telling the hotplug port
not to send interrupts is safe.

The issue that Command Complete events are falsely claimed to be
supported needs to be adressed regardless because whenever a
Thunderbolt device is unplugged, the same 2 second delay occurs.
So if you unplug a daisy chain of, say 6 devices, it takes 12
seconds until they're all removed from the system.

By now I've found out that Falcon Ridge (Thunderbolt 2) is not affected,
I'm not yet sure if Redwood Ridge is, but it seems the issue is contrained
to Thunderbolt 1 controllers only, probably an erratum.

Thanks,

Lukas