From: Keith Busch <keith.busch@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: poza@codeaurora.org, Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>, Wei Zhang <wzhang@fb.com>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event
Date: Thu, 18 Jan 2018 18:43:10 -0700 [thread overview]
Message-ID: <20180119014310.GA12043@localhost.localdomain> (raw)
In-Reply-To: <1629ca15-81f6-f5f4-8f9c-d0a575272dd6@codeaurora.org>
On Thu, Jan 18, 2018 at 11:35:59AM -0500, Sinan Kaya wrote:
> On 1/18/2018 12:32 AM, poza@codeaurora.org wrote:
> > On 2018-01-18 08:26, Keith Busch wrote:
> >> On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote:
> >>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
> >>> > +static bool dpc_wait_link_active(struct pci_dev *pdev)
> >>> > +{
> >>>
> >>> I think you can also make this function common instead of making another copy here.
> >>> Of course, this would be another patch.
> >>
> >> It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c,
> >> so there's some opprotunity to make even more common code.
> >
> > in that case there has to be a generic function in
> > drives/pci.c
> >
> > which addresses folowing functions from
> >
> > pcie-dpc.c:
> > dpc_wait_link_inactive
> > dpc_wait_link_active
> >
> > drivers/pci/hotplug/pciehp_hpc.c
> > pcie_wait_link_active
> >
> >
> > all aboe making one generic function to be moved to drives/pci.c
> >
> > please let me know if this is okay.
>
> Works for me. Keith/Bjorn?
Yep, I believe common solutions that reduce code is always encouraged
in the Linux kernel.
next prev parent reply other threads:[~2018-01-19 1:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:37 [PATCH v5 0/4] Address error and recovery for AER and DPC Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 1/4] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 2/4] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-01-17 16:45 ` Sinan Kaya
2018-01-18 5:22 ` poza
2018-01-18 6:04 ` poza
2018-01-17 16:46 ` Sinan Kaya
2018-01-18 5:17 ` poza
2018-01-18 5:57 ` poza
2018-01-18 16:31 ` Sinan Kaya
2018-01-18 18:00 ` poza
2018-01-18 18:03 ` Sinan Kaya
2018-01-19 4:23 ` poza
2018-01-19 4:44 ` Sinan Kaya
2018-01-19 9:03 ` poza
2018-01-17 10:37 ` [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
2018-01-17 16:27 ` Sinan Kaya
2018-01-18 2:56 ` Keith Busch
2018-01-18 5:32 ` poza
2018-01-18 16:35 ` Sinan Kaya
2018-01-19 1:43 ` Keith Busch [this message]
2018-01-19 4:21 ` poza
2018-01-18 5:26 ` poza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119014310.GA12043@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).