From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Dongdong Liu <liudongdong3@huawei.com>
Subject: Re: [PATCH 0/8] PCI/DPC: Simplify RP PIO logging
Date: Fri, 26 Jan 2018 16:15:58 -0700 [thread overview]
Message-ID: <20180126231558.GA21531@localhost.localdomain> (raw)
In-Reply-To: <20180126225043.58614.99920.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Jan 26, 2018 at 04:55:30PM -0600, Bjorn Helgaas wrote:
> These are almost all just cleanups.
>
> The only behavior change I intend is this: If a port does not support
> the "RP Extensions for DPC" and it reports an "RP PIO error", we
> previously read the RP PIO log registers. I don't know if that's a
> legal situation, but I couldn't find an explicit prohibition in the
> spec.
>
> Anyway, the rest is all cleanups and simplifications that are not
> intended to change any behavior.
>
> These are currently on my pci/dpc branch [1] on top of patches 3 and 5
> from your v2 series [2], Keith:
>
> 6b9045b34b57 PCI/DPC: Fix interrupt message number print
> eed85ff4c0da PCI/DPC: Enable DPC only if AER is available
>
> Your patch 1 ("PCI/AER: Return correct value when AER is not
> supported") is on pci/aer. Patches 2 and 4 go together and I think
> you're still working on those.
>
> You don't need to worry about integrating your work with these
> patches; I'm just kibbitzing and will drop these completely if you
> don't like them, or I'll take care of putting the pieces back together
> if you do.
No problem at all. I happened to pull your tree a few moments before you
posted this series, so I had a head start reviewing it. I'm happy with
the cleanups, and this doesn't trip up the updates I'm working on. I'm ok
to base the remaining DPC updates on this if you want to move it forward:
Reviewed-by: Keith Busch <keith.busch@intel.com>
I do need to merge pci/dpc with pci/aer to complete the rest of my DPC
updates, and there is a trivial merge conflict, but no biggie.
prev parent reply other threads:[~2018-01-26 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 22:55 [PATCH 0/8] PCI/DPC: Simplify RP PIO logging Bjorn Helgaas
2018-01-26 22:55 ` [PATCH 1/8] PCI/DPC: Rename interrupt_event_handler() to dpc_work() Bjorn Helgaas
2018-01-26 22:55 ` [PATCH 2/8] PCI/DPC: Add local variable for DPC capability offset Bjorn Helgaas
2018-01-26 22:55 ` [PATCH 3/8] PCI/DPC: Rename struct dpc_dev.rp to rp_extensions Bjorn Helgaas
2018-01-26 22:56 ` [PATCH 4/8] PCI/DPC: Read RP PIO Log Size once at probe Bjorn Helgaas
2018-01-26 22:56 ` [PATCH 5/8] PCI/DPC: Process RP PIO details only if RP PIO extensions supported Bjorn Helgaas
2018-01-26 22:56 ` [PATCH 6/8] PCI/DPC: Consolidate RP PIO get/print functions Bjorn Helgaas
2018-01-30 0:42 ` okaya
2018-01-30 18:11 ` Bjorn Helgaas
2018-01-26 22:56 ` [PATCH 7/8] PCI/DPC: Add and use DPC Status register field definitions Bjorn Helgaas
2018-01-26 22:56 ` [PATCH 8/8] PCI/DPC: Reformat DPC register definitions Bjorn Helgaas
2018-01-26 23:15 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126231558.GA21531@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).