From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Sinan Kaya <okaya@codeaurora.org>,
linux-pci@vger.kernel.org, Dongdong Liu <liudongdong3@huawei.com>
Subject: Re: [PATCH v2 11/14] PCI/DPC: Remove unnecessary RP PIO register structs
Date: Tue, 30 Jan 2018 11:57:58 -0700 [thread overview]
Message-ID: <20180130185758.GC27205@localhost.localdomain> (raw)
In-Reply-To: <20180130182648.106875.32803.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Tue, Jan 30, 2018 at 12:26:48PM -0600, Bjorn Helgaas wrote:
> + u16 cap = dpc->cap_pos;
> + u32 status, mask;
> + u32 sev, syserr, exc;
> + u16 dpc_status, first_error;
> + u32 dw0, dw1, dw2, dw3;
> + u32 log;
> + u32 prefix;
Minor nit, could you squash the declarations of the same type?
next prev parent reply other threads:[~2018-01-30 18:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 18:25 [PATCH v2 00/14] PCI/DPC: Simplify RP PIO logging Bjorn Helgaas
2018-01-30 18:25 ` [PATCH v2 01/14] PCI/DPC: Rename interrupt_event_handler() to dpc_work() Bjorn Helgaas
2018-01-30 18:25 ` [PATCH v2 02/14] PCI/DPC: Add local variable for DPC capability offset Bjorn Helgaas
2018-01-30 18:25 ` [PATCH v2 03/14] PCI/DPC: Rename struct dpc_dev.rp to rp_extensions Bjorn Helgaas
2018-01-30 18:25 ` [PATCH v2 04/14] PCI/DPC: Read RP PIO Log Size once at probe Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 05/14] PCI/DPC: Process RP PIO details only if RP PIO extensions supported Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 06/14] PCI/DPC: Squash dpc_rp_pio_print_tlp_header() into dpc_rp_pio_print_error() Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 07/14] PCI/DPC: Rename local "status" to "dpc_status" Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 08/14] PCI/DPC: Make RP PIO log size check more generic Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 09/14] PCI/DPC: Squash dpc_rp_pio_print_error() into dpc_rp_pio_get_info() Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 10/14] PCI/DPC: Push dpc->rp_pio_status assignment " Bjorn Helgaas
2018-01-30 18:26 ` [PATCH v2 11/14] PCI/DPC: Remove unnecessary RP PIO register structs Bjorn Helgaas
2018-01-30 18:57 ` Keith Busch [this message]
2018-01-30 19:11 ` Bjorn Helgaas
2018-01-30 19:43 ` Keith Busch
2018-01-30 18:26 ` [PATCH v2 12/14] PCI/DPC: Squash dpc_rp_pio_get_info() into dpc_process_rp_pio_error() Bjorn Helgaas
2018-01-30 18:27 ` [PATCH v2 13/14] PCI/DPC: Add and use DPC Status register field definitions Bjorn Helgaas
2018-01-30 18:27 ` [PATCH v2 14/14] PCI/DPC: Reformat DPC register definitions Bjorn Helgaas
2018-01-30 20:25 ` [PATCH v2 00/14] PCI/DPC: Simplify RP PIO logging Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130185758.GC27205@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox