* [PATCH 20/20] x86/PCI: VMD: Fix malformed default
[not found] <20180205012146.23981-1-ulfalizer@gmail.com>
@ 2018-02-05 1:21 ` Ulf Magnusson
2018-02-05 2:03 ` Ulf Magnusson
2018-02-06 19:11 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Ulf Magnusson @ 2018-02-05 1:21 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kbuild, tfiga, paul.burton, m.szyprowski, egtvedt,
linus.walleij, vgupta, mgorman, hch, mina86, robh, sboyd, paulus,
will.deacon, tony, npiggin, yamada.masahiro, Ulf Magnusson,
Lorenzo Pieralisi, Bjorn Helgaas, linux-pci
'default N' should be 'default n', though they happen to have the same
effect here, due to undefined symbols (N in this case) evaluating to n
in a tristate sense.
Remove the default from VMD instead of changing it. bool and tristate
symbols implicitly default to n.
Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
drivers/pci/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index a4ed7484d127..dc8a2a175f19 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
config VMD
depends on PCI_MSI && X86_64 && SRCU
tristate "Intel Volume Management Device Driver"
- default N
---help---
Adds support for the Intel Volume Management Device (VMD). VMD is a
secondary PCI host bridge that allows PCI Express root ports,
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default
2018-02-05 1:21 ` [PATCH 20/20] x86/PCI: VMD: Fix malformed default Ulf Magnusson
@ 2018-02-05 2:03 ` Ulf Magnusson
2018-02-06 19:11 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Magnusson @ 2018-02-05 2:03 UTC (permalink / raw)
To: Linux Kernel Mailing List, Ley Foon Tan
Cc: Linux Kbuild mailing list, tfiga, paul.burton, Marek Szyprowski,
Hans-Christian Noren Egtvedt, Linus Walleij, vgupta, mgorman, hch,
mina86, robh, sboyd, paulus, will.deacon, Tony Lindgren,
Nicholas Piggin, Masahiro Yamada, Ulf Magnusson,
Lorenzo Pieralisi, Bjorn Helgaas, linux-pci
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default from VMD instead of changing it. bool and tristate
> symbols implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
The PCIE_ALTERA symbol in this file also depends on the globally
undefined symbol OF_PCI, which was removed in 4670d610d592 ("PCI: Move
OF-related PCI functions into PCI core").
Cheers,
Ulf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default
2018-02-05 1:21 ` [PATCH 20/20] x86/PCI: VMD: Fix malformed default Ulf Magnusson
2018-02-05 2:03 ` Ulf Magnusson
@ 2018-02-06 19:11 ` Bjorn Helgaas
2018-02-06 22:17 ` Ulf Magnusson
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2018-02-06 19:11 UTC (permalink / raw)
To: Ulf Magnusson
Cc: linux-kernel, linux-kbuild, tfiga, paul.burton, m.szyprowski,
egtvedt, linus.walleij, vgupta, mgorman, hch, mina86, robh, sboyd,
paulus, will.deacon, tony, npiggin, yamada.masahiro,
Lorenzo Pieralisi, Bjorn Helgaas, linux-pci
> x86/PCI: VMD: Fix malformed default
In the title, please include a clue about what default you're talking
about, e.g., mention Kconfig somehow.
On Mon, Feb 05, 2018 at 02:21:32AM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default from VMD instead of changing it. bool and tristate
> symbols implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 20/20] x86/PCI: VMD: Fix malformed default
2018-02-06 19:11 ` Bjorn Helgaas
@ 2018-02-06 22:17 ` Ulf Magnusson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Magnusson @ 2018-02-06 22:17 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list, tfiga,
paul.burton, Marek Szyprowski, Hans-Christian Noren Egtvedt,
Linus Walleij, Vineet Gupta, mgorman, Christoph Hellwig, mina86,
Rob Herring, Stephen Boyd, Paul Mackerras, Will Deacon,
Tony Lindgren, Nicholas Piggin, Masahiro Yamada,
Lorenzo Pieralisi, Bjorn Helgaas, linux-pci
On Tue, Feb 6, 2018 at 8:11 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>> x86/PCI: VMD: Fix malformed default
>
> In the title, please include a clue about what default you're talking
> about, e.g., mention Kconfig somehow.
>
> On Mon, Feb 05, 2018 at 02:21:32AM +0100, Ulf Magnusson wrote:
>> 'default N' should be 'default n', though they happen to have the same
>> effect here, due to undefined symbols (N in this case) evaluating to n
>> in a tristate sense.
>>
>> Remove the default from VMD instead of changing it. bool and tristate
>> symbols implicitly default to n.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>> drivers/pci/host/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index a4ed7484d127..dc8a2a175f19 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
>> config VMD
>> depends on PCI_MSI && X86_64 && SRCU
>> tristate "Intel Volume Management Device Driver"
>> - default N
>> ---help---
>> Adds support for the Intel Volume Management Device (VMD). VMD is a
>> secondary PCI host bridge that allows PCI Express root ports,
>> --
>> 2.14.1
>>
Typoed the --in-reply-to. v2 is at https://lkml.org/lkml/2018/2/6/770
Cheers,
Ulf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-06 22:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180205012146.23981-1-ulfalizer@gmail.com>
2018-02-05 1:21 ` [PATCH 20/20] x86/PCI: VMD: Fix malformed default Ulf Magnusson
2018-02-05 2:03 ` Ulf Magnusson
2018-02-06 19:11 ` Bjorn Helgaas
2018-02-06 22:17 ` Ulf Magnusson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).