From: Thierry Reding <thierry.reding@gmail.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com, cyndis@kapsi.fi,
jonathanh@nvidia.com, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org, vidyas@nvidia.com,
kthota@nvidia.com
Subject: Re: [PATCH V7 4/4] PCI: tegra: Add power management support
Date: Tue, 13 Feb 2018 14:07:43 +0100 [thread overview]
Message-ID: <20180213130743.GF6764@ulmo> (raw)
In-Reply-To: <1517289851-14111-5-git-send-email-mmaddireddy@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On Tue, Jan 30, 2018 at 10:54:11AM +0530, Manikanta Maddireddy wrote:
> Tegra186 powergate driver is implemented as power domain driver, power
> partition ungate/gate are registered as power_on/power_off callback
> functions. There are no direct functions to power gate/ungate host
> controller in Tegra186. Host controller driver should add "power-domains"
> property in device tree and implement runtime suspend and resume
> callback functons. Power gate and ungate is taken care by power domain
> driver when host controller driver calls pm_runtime_put_sync and
> pm_runtime_get_sync respectively.
>
> Register suspend_noirq & resume_noirq callback functions to allow PCIe to
> come up after resume from RAM. Both runtime and noirq pm ops share same
> callback functions.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> ---
> V2:
> * no change in this patch
> V3:
> * no change in this patch
> V4:
> * no change in this patch
> V5:
> * Decoupled from https://patchwork.ozlabs.org/patch/832053/ and
> rebased on linux-next
> V6:
> * no change in this patch
> V7:
> * memory & irq alloc and AFI programming for MSI are split in two functions
>
> drivers/pci/host/pci-tegra.c | 178 +++++++++++++++++++++++++++----------------
> 1 file changed, 111 insertions(+), 67 deletions(-)
Looks good to me:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-13 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 5:24 [PATCH V7 0/4] Add loadable kernel module and power management support Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 1/4] PCI: tegra: Free resources on probe failure Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 2/4] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2018-02-13 11:39 ` Thierry Reding
2018-02-13 13:07 ` Thierry Reding
2018-02-13 13:18 ` Manikanta Maddireddy
2018-02-13 13:51 ` Thierry Reding
2018-02-13 15:26 ` Manikanta Maddireddy
2018-02-13 15:30 ` Manikanta Maddireddy
2018-01-30 5:24 ` [PATCH V7 3/4] PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2 Manikanta Maddireddy
2018-02-13 11:30 ` Thierry Reding
2018-01-30 5:24 ` [PATCH V7 4/4] PCI: tegra: Add power management support Manikanta Maddireddy
2018-02-13 13:07 ` Thierry Reding [this message]
2018-02-13 13:08 ` [PATCH V7 0/4] Add loadable kernel module and " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213130743.GF6764@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).