From: David Miller <davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
netdev@vger.kernel.org, hare@suse.de, nirranjan@chelsio.com,
indranil@chelsio.com, venkatesh@chelsio.com, leedom@chelsio.com,
stable@vger.kernel.org, arjun@chelsio.com
Subject: Re: [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices
Date: Fri, 16 Feb 2018 15:42:46 -0500 (EST) [thread overview]
Message-ID: <20180216.154246.733588003782380192.davem@davemloft.net> (raw)
In-Reply-To: <1518705198-15987-1-git-send-email-ganeshgr@chelsio.com>
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Thu, 15 Feb 2018 20:03:18 +0530
> From: Casey Leedom <leedom@chelsio.com>
>
> We've run into a problem where our device is attached
> to a Virtual Machine and the use of the new pci_set_vpd_size()
> API doesn't help. The VM kernel has been informed that
> the accesses are okay, but all of the actual VPD Capability
> Accesses are trapped down into the KVM Hypervisor where it
> goes ahead and imposes the silent denials.
>
> The right idea is to follow the kernel.org
> commit 1c7de2b4ff88 ("PCI: Enable access to non-standard VPD for
> Chelsio devices (cxgb3)") which Alexey Kardashevskiy authored
> to establish a PCI Quirk for our T3-based adapters. This commit
> extends that PCI Quirk to cover Chelsio T4 devices and later.
>
> The advantage of this approach is that the VPD Size gets set early
> in the Base OS/Hypervisor Boot and doesn't require that the cxgb4
> driver even be available in the Base OS/Hypervisor. Thus PF4 can
> be exported to a Virtual Machine and everything should work.
>
> Fixes: 67e658794ca1 ("cxgb4: Set VPD size so we can read both VPD structures")
> Cc: <stable@vger.kernel.org> # v4.9+
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
> Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Applied, thanks.
prev parent reply other threads:[~2018-02-16 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 14:33 [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices Ganesh Goudar
2018-02-16 20:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216.154246.733588003782380192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjun@chelsio.com \
--cc=bhelgaas@google.com \
--cc=ganeshgr@chelsio.com \
--cc=hare@suse.de \
--cc=indranil@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=stable@vger.kernel.org \
--cc=venkatesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).