From: Lukas Wunner <lukas@wunner.de>
To: George Cherian <gcherian@caviumnetworks.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, Jayachandran.Nair@cavium.com,
Robert.Richter@cavium.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173
Date: Wed, 21 Feb 2018 10:54:35 +0100 [thread overview]
Message-ID: <20180221095435.xe5lmes7mpxca3en@wunner.de> (raw)
In-Reply-To: <c8454323-06b2-e758-0d38-550c6b31b15e@caviumnetworks.com>
On Wed, Feb 21, 2018 at 02:58:13PM +0530, George Cherian wrote:
> I will explain the setup used
> To the Cavium ThunderX RC the following PLX device is connected.
> PLX Technology, Inc. PEX 8747 48-Lane, 5-Port PCI Express Gen 3 (8.0 GT/s)
> Switch
> There is no device connected downstream to the PLX switch.
>
> AFAIU the pcie_port driver probes PLX and enters autosuspend after 100ms
> since pci_bridge_d3_possible() returns true.
>
> And later pci_sysfs_init() ends up doing a config access of PLX which fails
> with a "synchronous external abort"
Then you're missing a pci_config_pm_runtime_get() in pci_sysfs_init() or
further down in the call stack, rather than a quirk which just papers
over the issue.
Thanks,
Lukas
next prev parent reply other threads:[~2018-02-21 9:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 7:00 [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173 George Cherian
2018-02-13 6:23 ` Jayachandran C
2018-02-13 15:09 ` Bjorn Helgaas
2018-02-14 11:28 ` George Cherian
2018-02-14 20:16 ` Bjorn Helgaas
2018-02-15 21:57 ` Rafael J. Wysocki
2018-02-15 23:39 ` Bjorn Helgaas
2018-02-16 12:40 ` Rafael J. Wysocki
2018-02-16 20:34 ` Bjorn Helgaas
2018-02-19 11:21 ` Rafael J. Wysocki
2018-02-19 20:36 ` Bjorn Helgaas
2018-02-20 1:54 ` Lukas Wunner
2018-02-20 10:58 ` Rafael J. Wysocki
2018-02-20 19:00 ` Bjorn Helgaas
2018-02-21 9:28 ` George Cherian
2018-02-21 9:54 ` Lukas Wunner [this message]
2018-02-21 10:55 ` George Cherian
2018-02-21 23:20 ` Bjorn Helgaas
2018-02-22 8:35 ` Lukas Wunner
2018-02-22 10:19 ` Rafael J. Wysocki
2018-02-22 13:13 ` George Cherian
2018-02-22 15:09 ` Bjorn Helgaas
2018-03-13 14:13 ` George Cherian
2018-02-19 19:08 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221095435.xe5lmes7mpxca3en@wunner.de \
--to=lukas@wunner.de \
--cc=Jayachandran.Nair@cavium.com \
--cc=Robert.Richter@cavium.com \
--cc=bhelgaas@google.com \
--cc=gcherian@caviumnetworks.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox