From: Christoph Hellwig <hch@infradead.org>
To: Oza Pawandeep <poza@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Sinan Kaya <okaya@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v10 6/7] PCI: Unify wait for link active into generic pci
Date: Thu, 22 Feb 2018 10:43:48 -0800 [thread overview]
Message-ID: <20180222184348.GE6267@infradead.org> (raw)
In-Reply-To: <1519315332-26852-7-git-send-email-poza@codeaurora.org>
>
> +/**
> + * pci__wait_for_link - Wait for link till its active/inactive
typo - just wants a single underscore.
> + pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> + ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
no need for the !! when assigning to a boolean.
> +
> + while ((ret != active) && (timeout > 0)) {
No need for either pair of inner braces.
> + msleep(10);
> + timeout -= 10;
> + pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> + ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
Same as above.
> + }
> +
> + if (ret == active)
> + return true;
Seems like the structure is a bit odd. Why not:
for (;;) {
pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
if ((lnk_status & PCI_EXP_LNKSTA_DLLLA) == active)
return true;
if (timeout <= 0)
break;
timeout -= 10;
}
next prev parent reply other threads:[~2018-02-22 18:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 16:02 [PATCH v10 0/7] Address error and recovery for AER and DPC Oza Pawandeep
2018-02-22 16:02 ` [PATCH v10 1/7] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-02-22 18:34 ` Christoph Hellwig
2018-02-23 5:24 ` poza
2018-02-22 16:02 ` [PATCH v10 2/7] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-02-22 18:34 ` Christoph Hellwig
2018-02-22 18:42 ` David Laight
2018-02-22 16:02 ` [PATCH v10 3/7] PCI/ERR: add mutex to synchronize recovery Oza Pawandeep
2018-02-22 18:36 ` Christoph Hellwig
2018-02-23 5:27 ` poza
2018-02-22 16:02 ` [PATCH v10 4/7] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-02-22 18:39 ` Christoph Hellwig
2018-02-23 5:28 ` poza
2018-02-22 16:02 ` [PATCH v10 5/7] PCI/AER: Unify aer error defines at single space Oza Pawandeep
2018-02-22 16:06 ` poza
2018-02-22 16:02 ` [PATCH v10 6/7] PCI: Unify wait for link active into generic pci Oza Pawandeep
2018-02-22 18:43 ` Christoph Hellwig [this message]
2018-02-23 6:53 ` poza
2018-02-22 16:02 ` [PATCH v10 7/7] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222184348.GE6267@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).