From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Colin King <colin.king@canonical.com>
Cc: Simon Horman <horms@verge.net.au>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT
Date: Fri, 23 Feb 2018 14:06:43 +0000 [thread overview]
Message-ID: <20180223140643.GA24211@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20180223122949.24291-1-colin.king@canonical.com>
On Fri, Feb 23, 2018 at 12:29:49PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice;
> remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pci/host/pci-rcar-gen2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
Applied to pci/rcar for v4.17, thanks !
Lorenzo
> index a28370bb2b2a..dd4f1a6b57c5 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -52,7 +52,6 @@
> #define RCAR_PCI_INT_B (1 << 17)
> #define RCAR_PCI_INT_PME (1 << 19)
> #define RCAR_PCI_INT_ALLERRORS (RCAR_PCI_INT_SIGTABORT | \
> - RCAR_PCI_INT_SIGRETABORT | \
> RCAR_PCI_INT_SIGRETABORT | \
> RCAR_PCI_INT_REMABORT | \
> RCAR_PCI_INT_PERR | \
> --
> 2.15.1
>
prev parent reply other threads:[~2018-02-23 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 12:29 [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT Colin King
2018-02-23 12:35 ` Geert Uytterhoeven
2018-02-23 14:06 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223140643.GA24211@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=colin.king@canonical.com \
--cc=horms@verge.net.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).