* [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT
@ 2018-02-23 12:29 Colin King
2018-02-23 12:35 ` Geert Uytterhoeven
2018-02-23 14:06 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-02-23 12:29 UTC (permalink / raw)
To: Simon Horman, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
linux-renesas-soc
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice;
remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pci/host/pci-rcar-gen2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
index a28370bb2b2a..dd4f1a6b57c5 100644
--- a/drivers/pci/host/pci-rcar-gen2.c
+++ b/drivers/pci/host/pci-rcar-gen2.c
@@ -52,7 +52,6 @@
#define RCAR_PCI_INT_B (1 << 17)
#define RCAR_PCI_INT_PME (1 << 19)
#define RCAR_PCI_INT_ALLERRORS (RCAR_PCI_INT_SIGTABORT | \
- RCAR_PCI_INT_SIGRETABORT | \
RCAR_PCI_INT_SIGRETABORT | \
RCAR_PCI_INT_REMABORT | \
RCAR_PCI_INT_PERR | \
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT
2018-02-23 12:29 [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT Colin King
@ 2018-02-23 12:35 ` Geert Uytterhoeven
2018-02-23 14:06 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-02-23 12:35 UTC (permalink / raw)
To: Colin King
Cc: Simon Horman, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
Linux-Renesas, kernel-janitors, Linux Kernel Mailing List
On Fri, Feb 23, 2018 at 1:29 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice;
> remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT
2018-02-23 12:29 [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT Colin King
2018-02-23 12:35 ` Geert Uytterhoeven
@ 2018-02-23 14:06 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-23 14:06 UTC (permalink / raw)
To: Colin King
Cc: Simon Horman, Bjorn Helgaas, linux-pci, linux-renesas-soc,
kernel-janitors, linux-kernel
On Fri, Feb 23, 2018 at 12:29:49PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice;
> remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pci/host/pci-rcar-gen2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
Applied to pci/rcar for v4.17, thanks !
Lorenzo
> index a28370bb2b2a..dd4f1a6b57c5 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -52,7 +52,6 @@
> #define RCAR_PCI_INT_B (1 << 17)
> #define RCAR_PCI_INT_PME (1 << 19)
> #define RCAR_PCI_INT_ALLERRORS (RCAR_PCI_INT_SIGTABORT | \
> - RCAR_PCI_INT_SIGRETABORT | \
> RCAR_PCI_INT_SIGRETABORT | \
> RCAR_PCI_INT_REMABORT | \
> RCAR_PCI_INT_PERR | \
> --
> 2.15.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-23 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 12:29 [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT Colin King
2018-02-23 12:35 ` Geert Uytterhoeven
2018-02-23 14:06 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).