From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario.Limonciello@dell.com
Cc: helgaas@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net,
andriy.shevchenko@linux.intel.com, lenb@kernel.org,
michael.jamet@intel.com, yehezkel.bernat@intel.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/5] PCI: Make sure all bridges reserve at least one bus number
Date: Mon, 26 Feb 2018 12:24:36 +0200 [thread overview]
Message-ID: <20180226102436.GH27191@lahna.fi.intel.com> (raw)
In-Reply-To: <5506aacec14e4696a6f306ebd7df6fd2@ausx13mpc120.AMER.DELL.COM>
On Fri, Feb 23, 2018 at 07:06:59PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > Sent: Friday, February 23, 2018 11:26 AM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: bhelgaas@google.com; rjw@rjwysocki.net;
> > andriy.shevchenko@linux.intel.com; lenb@kernel.org; michael.jamet@intel.com;
> > yehezkel.bernat@intel.com; linux-acpi@vger.kernel.org; linux-
> > pci@vger.kernel.org; mika.westerberg@linux.intel.com
> > Subject: Re: [PATCH v2 1/5] PCI: Make sure all bridges reserve at least one bus
> > number
> >
> > On Fri, Feb 23, 2018 at 12:52:18AM +0000, Mario.Limonciello@dell.com wrote:
> > > On Feb 22, 2018 18:27, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > > On Thu, Feb 15, 2018 at 05:39:55PM +0300, Mika Westerberg wrote:
> > > > > When distributing extra buses between hotplug bridges we need to make
> > > > > sure each bridge reserve at least one bus number, even if there is
> > > > > currently nothing connected to it. For instance ACPI hotplug may bring
> > > > > in additional devices to non-hotplug bridges later on. To make sure we
> > > > > don't run out of bus numbers for non-hotplug bridges reserve one bus
> > > > > number for them upfront before distributing buses for hotplug bridges.
> > > > >
> > > > > Fixes: 1c02ea810065 ("PCI: Distribute available buses to hotplug-capable
> > bridges")
> > > > > Reported-by: Mario Limonciello <mario.limonciello@dell.com>
> > > >
> > > > Is there a bugzilla or email URL we can include here?
> > >
> > > Sorry it was private communication that I believe Mika is referring to in Reported-
> > By here.
> > >
> > > You can remove the tag if you think it's inappropriate for this commit.
> >
> > I like to give credit whenever possible, so I wouldn't necessarily
> > remove the Reported-by.
> >
> > But it would be very useful to also have a URL to something with more
> > details, e.g., what sort of failure the user would observe, dmesg
> > logs, PCI topology, etc.
> >
> > This information can certainly be redacted to remove any proprietary
> > things that can't be made public. Usually that isn't of interest to
> > structural issues like this anyway.
>
> It was a result of a very long communication chain, but I think I pulled
> out the relevant details here if you would like a URL to include:
> https://gist.github.com/superm1/100a2ed20449f684ebb84c392e35dbed
Thanks Mario.
I'll update changelog to include the above information as well.
next prev parent reply other threads:[~2018-02-26 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 14:39 [PATCH v2 0/5] PCI: Fixes for native PCIe and ACPI hotplug Mika Westerberg
2018-02-15 14:39 ` [PATCH v2 1/5] PCI: Make sure all bridges reserve at least one bus number Mika Westerberg
2018-02-15 15:51 ` Rafael J. Wysocki
2018-02-23 0:27 ` Bjorn Helgaas
2018-02-23 0:52 ` Mario.Limonciello
2018-02-23 17:25 ` Bjorn Helgaas
2018-02-23 19:06 ` Mario.Limonciello
2018-02-26 10:24 ` Mika Westerberg [this message]
2018-02-15 14:39 ` [PATCH v2 2/5] PCI: Take bridge window alignment into account when distributing resources Mika Westerberg
2018-02-15 14:39 ` [PATCH v2 3/5] PCI: pciehp: Clear Presence Detect and Data Link Layer Status Changed on resume Mika Westerberg
2018-02-15 14:39 ` [PATCH v2 4/5] ACPI / hotplug / PCI: Do not scan all bridges when native PCIe hotplug is used Mika Westerberg
2018-02-15 14:39 ` [PATCH v2 5/5] ACPI / hotplug / PCI: Mark stale PCI devices disconnected Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226102436.GH27191@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=rjw@rjwysocki.net \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).