From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:58969 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbeBZQbl (ORCPT ); Mon, 26 Feb 2018 11:31:41 -0500 Date: Mon, 26 Feb 2018 17:31:37 +0100 From: Jean Delvare To: Andy Shevchenko Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/4] ACPI / sleep: Re-use new dmi_get_bios_year() helper Message-ID: <20180226173137.3749baa7@endymion> In-Reply-To: <20180222125923.57385-3-andriy.shevchenko@linux.intel.com> References: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> <20180222125923.57385-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, 22 Feb 2018 14:59:22 +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/sleep.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > index 46cde0912762..b35923e3a926 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -376,12 +376,10 @@ void __init acpi_sleep_no_blacklist(void) > > static void __init acpi_sleep_dmi_check(void) > { > - int year; > - > if (ignore_blacklist) > return; > > - if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) && year >= 2012) > + if (dmi_get_bios_year() >= 2012) > acpi_nvs_nosave_s3(); > > dmi_check_system(acpisleep_dmi_table); Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support