From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 26 Feb 2018 21:40:22 +0100 From: Jean Delvare To: Andy Shevchenko Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper Message-ID: <20180226214022.7b239783@endymion> In-Reply-To: <20180222125923.57385-4-andriy.shevchenko@linux.intel.com> References: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> <20180222125923.57385-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: On Thu, 22 Feb 2018 14:59:23 +0200, Andy Shevchenko wrote: > ...instead of open coding its functionality. > > Signed-off-by: Andy Shevchenko > --- > drivers/pci/pci.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index f6a4dd10d9b0..ae654e21439d 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2258,8 +2258,6 @@ void pci_config_pm_runtime_put(struct pci_dev *pdev) > */ > bool pci_bridge_d3_possible(struct pci_dev *bridge) > { > - unsigned int year; > - > if (!pci_is_pcie(bridge)) > return false; > > @@ -2287,10 +2285,8 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > * It should be safe to put PCIe ports from 2015 or newer > * to D3. > */ > - if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) && > - year >= 2015) { > + if (dmi_get_bios_year() >= 2015) > return true; > - } > break; > } > Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support