linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: marc.zyngier@arm.com, Joao.Pinto@synopsys.com,
	bhelgaas@google.com, jingoohan1@gmail.com, kishon@ti.com,
	linux-pci@vger.kernel.org, m-karicheri2@ti.com,
	thomas.petazzoni@free-electrons.com, minghuan.Lian@freescale.com,
	mingkai.hu@freescale.com, tie-fei.zang@freescale.com,
	hongxing.zhu@nxp.com, l.stach@pengutronix.de,
	niklas.cassel@axis.com, jesper.nilsson@axis.com,
	wangzhou1@hisilicon.com, svarbanov@mm-sol.com, nsekhar@ti.com,
	Shawn Guo <shawn.guo@linaro.org>, Vignesh R <vigneshr@ti.com>,
	Pratyush Anand <pratyush.anand@gmail.com>
Subject: Re: [PATCH v9 0/3] PCI: dwc: Enables MSI-X driver support
Date: Fri, 2 Mar 2018 18:03:20 +0000	[thread overview]
Message-ID: <20180302180320.GA5404@red-moon> (raw)
In-Reply-To: <cover.1519834018.git.gustavo.pimentel@synopsys.com>

[+cc Shawn, Vignesh, Pratyush]
On Wed, Feb 28, 2018 at 04:10:22PM +0000, Gustavo Pimentel wrote:
> Changes into a new IRQ handler mechanism (multiplexed IRQ domain hierarchy)
> more suitable and appropriate to use on pcie-designware and on each SoC
> specific driver in order to allow new and more complex features like MSI-X.
> 
> Adds Synopsys Root Complex driver support for MSI-X feature.
> 
> Expands the maximum number of IRQs from 32 to 256 distributed by
> a maximum of 8 controller registers.
> 
> The patch set was made against the Bjorn's master branch (v4.16-rc1).
> 
> Gustavo Pimentel (3):
>   PCI: dwc: Add new IRQ API
>   PCI: dwc: Remove old IRQ API
>   PCI: dwc: Expand maximum number of IRQs from 32 to 256
> 
>  drivers/pci/dwc/pci-exynos.c           |  18 --
>  drivers/pci/dwc/pci-imx6.c             |  18 --
>  drivers/pci/dwc/pci-keystone-dw.c      |  91 +-------
>  drivers/pci/dwc/pci-keystone.c         |   1 +
>  drivers/pci/dwc/pci-keystone.h         |   4 +-
>  drivers/pci/dwc/pci-layerscape.c       |   3 +-
>  drivers/pci/dwc/pcie-artpec6.c         |  18 --
>  drivers/pci/dwc/pcie-designware-host.c | 398 +++++++++++++++++++--------------

Hi Gustavo,

I was reviewing a patch and this raised a question:

-  why pcie-histb.c is not in the list of converted drivers above,
   given that it uses dw_handle_msi_irq() the same way as others
   you converted ?

Is it correct to leave pcie-histb.c as-is ? I do not think it is.

I also would like to get this tested on DRA7 and SPEAR13XX which
are the other host drivers using dw_handle_msi_irq() (even though
in a different way than pcie-histb.c).

The difference here seems to be struct pcie_port->msi_irq usage, that's
extremely confusing how it is used (or not used) in the drivers I
mentioned above.

I have CC'ed the related maintainers I need feedback and this needs
testing; this series code is in my branch:

pci/dwc-msi

Thanks,
Lorenzo

>  drivers/pci/dwc/pcie-designware-plat.c |  16 --
>  drivers/pci/dwc/pcie-designware.h      |  30 ++-
>  drivers/pci/dwc/pcie-qcom.c            |  16 --
>  11 files changed, 258 insertions(+), 355 deletions(-)
> 
> -- 
> 2.7.4
> 
> 

  parent reply	other threads:[~2018-03-02 18:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 16:10 [PATCH v9 0/3] PCI: dwc: Enables MSI-X driver support Gustavo Pimentel
2018-02-28 16:10 ` [PATCH v9 1/3] PCI: dwc: Add new IRQ API Gustavo Pimentel
2018-03-01 11:33   ` Lorenzo Pieralisi
2018-03-01 12:50     ` Gustavo Pimentel
2018-02-28 16:10 ` [PATCH v9 2/3] PCI: dwc: Remove old " Gustavo Pimentel
2018-02-28 16:10 ` [PATCH v9 3/3] PCI: dwc: Expand maximum number of IRQs from 32 to 256 Gustavo Pimentel
2018-02-28 18:12 ` [PATCH v9 0/3] PCI: dwc: Enables MSI-X driver support Marc Zyngier
2018-03-01 11:35 ` Lorenzo Pieralisi
2018-03-02 18:03 ` Lorenzo Pieralisi [this message]
2018-03-05 18:22   ` Gustavo Pimentel
2018-03-06  8:23     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302180320.GA5404@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=jesper.nilsson@axis.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=marc.zyngier@arm.com \
    --cc=minghuan.Lian@freescale.com \
    --cc=mingkai.hu@freescale.com \
    --cc=niklas.cassel@axis.com \
    --cc=nsekhar@ti.com \
    --cc=pratyush.anand@gmail.com \
    --cc=shawn.guo@linaro.org \
    --cc=svarbanov@mm-sol.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tie-fei.zang@freescale.com \
    --cc=vigneshr@ti.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).