linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Jonathan Derrick <jonathan.derrick@intel.com>,
	Scott Bauer <scott.bauer@intel.com>
Subject: Re: [PATCHv2] PCI: vmd: Use affinity to chain child device interrupts
Date: Tue, 13 Mar 2018 17:24:40 -0600	[thread overview]
Message-ID: <20180313232440.GA28358@localhost.localdomain> (raw)
In-Reply-To: <20180313201807.GA28112@localhost.localdomain>

On Tue, Mar 13, 2018 at 02:18:07PM -0600, Keith Busch wrote:
> 
> And since you brought my attention to it, I see the 'if' is off by one.
> Let me prepare a v3, and I've one other minor optimization to add as
> well.

Ugh, I may need to request withdrawing this patch entirely. This will
completely break if the VMD interrupt vector's SMP affinity is a subset
of the child driver's, and the CPUs in the intersection of those masks
are set offline after driver initialization.

That's looking like a pretty tricky problem to fix, all for (somewhat)
obscure kernel feature... I can't see how without a new hot cpu notifier.

Let me request a pause on this one and I'll get back ASAP.

  reply	other threads:[~2018-03-13 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 20:22 [PATCHv2] PCI: vmd: Use affinity to chain child device interrupts Keith Busch
2018-03-13 17:10 ` Lorenzo Pieralisi
2018-03-13 20:08   ` Keith Busch
2018-03-13 20:18     ` Keith Busch
2018-03-13 23:24       ` Keith Busch [this message]
2018-03-14 11:05         ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313232440.GA28358@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=bhelgaas@google.com \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).