From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:34593 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbeCNIyX (ORCPT ); Wed, 14 Mar 2018 04:54:23 -0400 Date: Wed, 14 Mar 2018 09:54:21 +0100 From: Christoph Hellwig To: Alexander Duyck Cc: bhelgaas@google.com, alexander.h.duyck@intel.com, linux-pci@vger.kernel.org, virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, netanel@amazon.com, ddutile@redhat.com, mheyne@amazon.de, liang-min.wang@intel.com, mark.d.rustad@intel.com, dwmw2@infradead.org, hch@lst.de, dwmw@amazon.co.uk Subject: Re: [pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources Message-ID: <20180314085421.GA28796@lst.de> References: <20180313212508.3553.65326.stgit@localhost.localdomain> <20180313212754.3553.72176.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180313212754.3553.72176.stgit@localhost.localdomain> Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Mar 13, 2018 at 02:28:49PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch adds a common configuration function called > pci_sriov_configure_simple that will allow for managing VFs on devices > where the PF is not capable of managing VF resources. > > Signed-off-by: Alexander Duyck > --- > > v5: New patch replacing pci_sriov_configure_unmanaged with > pci_sriov_configure_simple > Dropped bits related to autoprobe changes > v6: Defined pci_sriov_configure_simple as NULL if IOV is disabled > > drivers/pci/iov.c | 32 ++++++++++++++++++++++++++++++++ > include/linux/pci.h | 3 +++ > 2 files changed, 35 insertions(+) > > diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c > index 677924ae0350..bd7021491fdb 100644 > --- a/drivers/pci/iov.c > +++ b/drivers/pci/iov.c > @@ -807,3 +807,35 @@ int pci_sriov_get_totalvfs(struct pci_dev *dev) > return dev->sriov->total_VFs; > } > EXPORT_SYMBOL_GPL(pci_sriov_get_totalvfs); > + > +/** > + * pci_sriov_configure_simple - helper to configure unmanaged SR-IOV > + * @dev: the PCI device > + * @nr_virtfn: number of virtual functions to enable, 0 to disable > + * > + * Used to provide generic enable/disable SR-IOV option for devices > + * that do not manage the VFs generated by their driver > + */ > +int pci_sriov_configure_simple(struct pci_dev *dev, int nr_virtfn) > +{ > + int err = -EINVAL; This assignment seems like it is never used.. > + > + might_sleep(); > + > + if (!dev->is_physfn) > + return -ENODEV; > + > + if (pci_vfs_assigned(dev)) { > + pci_warn(dev, > + "Cannot modify SR-IOV while VFs are assigned\n"); > + err = -EPERM; Why not: if (pci_vfs_assigned(dev)) { pci_warn(dev, "Cannot modify SR-IOV while VFs are assigned\n"); return -EPERM; } Otherwise looks good: Reviewed-by: Christoph Hellwig