From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Keith Busch <keith.busch@intel.com>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI/DPC: Disable interrupt generation during suspend
Date: Wed, 14 Mar 2018 13:33:32 +0100 [thread overview]
Message-ID: <20180314123332.GC19651@wunner.de> (raw)
In-Reply-To: <20180314120547.GB2703@lahna.fi.intel.com>
On Wed, Mar 14, 2018 at 02:05:47PM +0200, Mika Westerberg wrote:
> On Wed, Mar 14, 2018 at 12:48:49PM +0100, Rafael J. Wysocki wrote:
> > Have you considered putting these things into the ->suspend_late and
> > ->resume_early callbacks, respectively?
> >
> > That might be slightly better as runtime resume is still enabled when
> > the ->suspend and ->resume callbacks run.
>
> There is no ->suspend_late or ->resume_early callbacks in struct
> pcie_port_service_driver so I followed what drivers/pci/pcie/pme.c is
> doing. I guess we could add those callbacks as well if you think they
> are better suited here.
Maybe these two commits I did 2 years ago but never upstreamed are of help:
https://github.com/l1k/linux/commit/4f59372f830899e89fea9ba7c090680900d5998e
https://github.com/l1k/linux/commit/ce63b6ed01602e77c56043ee6dfa52ca9d257f88
I'm not sure if they still compile & work, sorry. :)
Thanks,
Lukas
next prev parent reply other threads:[~2018-03-14 12:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:41 [PATCH 1/2] PCI/DPC: Disable interrupt generation during suspend Mika Westerberg
2018-03-14 11:41 ` [PATCH 2/2] PCI/DPC: Do not enable DPC if AER control is not allowed by the BIOS Mika Westerberg
2018-03-14 11:50 ` Rafael J. Wysocki
2018-03-14 12:07 ` Mika Westerberg
2018-03-14 11:48 ` [PATCH 1/2] PCI/DPC: Disable interrupt generation during suspend Rafael J. Wysocki
2018-03-14 12:05 ` Mika Westerberg
2018-03-14 12:33 ` Lukas Wunner [this message]
2018-03-20 10:45 ` Mika Westerberg
2018-03-20 11:35 ` Lukas Wunner
2018-03-22 10:45 ` Lukas Wunner
2018-03-22 16:53 ` Mika Westerberg
2018-03-22 17:39 ` Lukas Wunner
2018-03-22 19:36 ` Bjorn Helgaas
2018-03-23 11:18 ` Mika Westerberg
2018-03-23 21:08 ` Bjorn Helgaas
2018-03-23 21:11 ` Rafael J. Wysocki
2018-03-23 22:01 ` Bjorn Helgaas
2018-03-24 10:48 ` Rafael J. Wysocki
2018-03-24 12:15 ` Lukas Wunner
2018-03-24 13:48 ` Lukas Wunner
2018-03-24 14:09 ` Bjorn Helgaas
2018-03-26 9:55 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314123332.GC19651@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).