Re: [PATCH RESEND v4 8/9] PCI: Improve "partially hidden behind bridge" log message

[Mika Westerberg <mika.westerberg@linux.intel.com>]

On Tue, Apr 10, 2018 at 05:04:53PM +0200, Rafael J. Wysocki wrote:
> On Tuesday, April 3, 2018 4:52:24 PM CEST Mika Westerberg wrote:
> > There is a sanity checker in the end of pci_scan_child_bus_extend() that
> > tries to detect badly configured bridges. For example given the below
> > topology:
> > 
> >   +-1b.0-[01-39]----00.0-[02-3a]--+-00.0-[03]----00.0
> >                                   +-01.0-[04-39]--
> >                                   \-02.0-[3a]----00.0
> > 
> > The sanity checker notices this and logs following messages:
> > 
> >   pci_bus 0000:3a: [bus 3a] partially hidden behind bridge 0000:02 [bus 02-39]
> >   pci_bus 0000:3a: [bus 3a] partially hidden behind bridge 0000:01 [bus 01-39]
> > 
> > This is not really helpful to users and the information above is not
> > even correct (0000:02 is a bus not bridge). Make this a bit more
> > understandable by changing the sanity checker to log following message
> > in place of the above two messages:
> > 
> >   pci 0000:02:02.0: devices behind bridge are unusable because we cannot assign [bus 3a] for them
> 
> FWIW, I prefer to use passive voice in messages, like
> 
>  devices behind bridge are unusable, because [bus 3a] cannot be assigned for them

Works for me :)

I'll update the message accordingly then.