From: Christoph Hellwig <hch@infradead.org>
To: Frederick Lawler <fred@fredlawl.com>
Cc: bhelgaas@google.com, mike.marciniszyn@intel.com,
dennis.dalessandro@intel.com, dledford@redhat.com,
jgg@mellanox.com, linux-pci@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration
Date: Mon, 16 Apr 2018 23:53:43 -0700 [thread overview]
Message-ID: <20180417065343.GA29193@infradead.org> (raw)
In-Reply-To: <20180417002825.2737-1-fred@fredlawl.com>
On Mon, Apr 16, 2018 at 07:28:23PM -0500, Frederick Lawler wrote:
> The IB/hfi1 driver uses custom macros to configure the target link speed. Some
> macros were previously replaced, but not fully. This patch series addresses the
> configuration inconsistencies by adding PCI_EXP_LNKCTL2_TLS* macros to PCI,
> and then use them in the following IB/hfi1 patch.
Btw, why is the driver configuring the PCIe link speed? Isn't this
something we should be handling in the PCI core?
next prev parent reply other threads:[~2018-04-17 6:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 0:28 [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration Frederick Lawler
2018-04-17 0:28 ` [PATCH v3 1/2] PCI: Add PCI_EXP_LNKCTL2_TLS* macros Frederick Lawler
2018-04-17 0:28 ` [PATCH v3 2/2] IB/hfi1: Replace custom hfi1 macros with PCIe macros Frederick Lawler
2018-04-20 18:21 ` Ruhl, Michael J
2018-04-17 6:53 ` Christoph Hellwig [this message]
2018-04-17 14:32 ` [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration Bjorn Helgaas
2018-04-18 21:53 ` Dennis Dalessandro
2018-04-17 15:56 ` Marciniszyn, Mike
2018-04-17 17:19 ` Bjorn Helgaas
2018-04-20 17:03 ` Dennis Dalessandro
2018-04-27 16:14 ` Doug Ledford
2018-04-27 17:58 ` Bjorn Helgaas
2018-04-27 18:18 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417065343.GA29193@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=fred@fredlawl.com \
--cc=jgg@mellanox.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).