From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com, jespern@axis.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: artpec6: Use devm_ioremap_resource instead of devm_ioremap_resource
Date: Wed, 18 Apr 2018 22:59:30 +0200 [thread overview]
Message-ID: <20180418205930.GY16746@axis.com> (raw)
In-Reply-To: <828d8a53d85be073672fec67ee6980818dc459ab.1524038460.git.gustavo.pimentel@synopsys.com>
On Wed, Apr 18, 2018 at 09:06:33AM +0100, Gustavo Pimentel wrote:
> This fix aims to replace the use of devm_ioremap() by
> devm_ioremap_resource() already discussed on [1].
>
> [1] -> https://patchwork.kernel.org/patch/10173831/
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Looks good:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> ---
> drivers/pci/dwc/pcie-artpec6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
> index e66cede..321b56c 100644
> --- a/drivers/pci/dwc/pcie-artpec6.c
> +++ b/drivers/pci/dwc/pcie-artpec6.c
> @@ -463,9 +463,9 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *artpec6_pcie,
> ep->ops = &pcie_ep_ops;
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2");
> - pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res));
> - if (!pci->dbi_base2)
> - return -ENOMEM;
> + pci->dbi_base2 = devm_ioremap_resource(dev, res);
> + if (IS_ERR(pci->dbi_base2))
> + return PTR_ERR(pci->dbi_base2);
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
> if (!res)
> --
> 2.7.4
>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2018-04-18 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 8:06 [PATCH] PCI: dwc: artpec6: Use devm_ioremap_resource instead of devm_ioremap_resource Gustavo Pimentel
2018-04-18 20:59 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418205930.GY16746@axis.com \
--to=jesper.nilsson@axis.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jespern@axis.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).