Re: [PATCH 0/2] PCI: Support to workaround bus level HW issues

[Alex Williamson <alex.williamson@redhat.com>]

On Thu, 19 Apr 2018 13:36:00 -0400
James Puthukattukaran <james.puthukattukaran@oracle.com> wrote:

> There are bugs in certain PCIe switches that cause access violations
>  when an endpoint device is hotplugged. In particular, there's an issue
> with
> certain IDT switches that trigger a ACS violation when bringing up a newly
> plugged PCIe endpoint device. This is a major issue for platforms
> designed to
> issue a fatal reset in the case of this event.
> 
> The first patch provides a framework for intercepting and working around
> issues with parent devices to the endpoint being brought up.
> 
> The second patch provides the actual patch for the IDT switch issue using
> that framework. The ACS feature is disabled in the IDT switch prior to
> endpoint
> device detection and then re-enabled subsequent to that.

I'm happy with the logic of the patch, but:

 - Patches are lined wrapped
 - There are white space issues (space indenting and extra returns)
 - 'return(foo(bar));' has too many parens, using 'return foo(bar);'
 - Comment style, see Documentation/process/coding-style.rst for
   preferred multi-line inline comment style.  (I see mixed comment
   style in quirks.c, but probe.c is pretty consistent)
 - Please don't fixup style issues in patch 1/2 in patch 2/2

scripts/checkpatch.pl can find some of these for you.  Thanks,

Alex