From: Christoph Hellwig <hch@infradead.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/9] PCI: Add pci_alloc_intx_irqd() for allocating IRQ domain
Date: Sat, 28 Apr 2018 10:59:25 -0700 [thread overview]
Message-ID: <20180428175925.GA17528@infradead.org> (raw)
In-Reply-To: <1524880132-100904-1-git-send-email-shawn.lin@rock-chips.com>
On Sat, Apr 28, 2018 at 09:48:52AM +0800, Shawn Lin wrote:
> It seems host drivers which allocate IRQ domain for INTx
> and the related code block looks highly similar to each other.
> Add a new helper, pci_alloc_intx_irqd(), to avoid code duplication
> as much as possible.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Maybe add a _host to the name as in pci_host_alloc_intx_irqdomain,
and potentially move it to a different file than irq.c, as that contains
helpers for drivers.
next prev parent reply other threads:[~2018-04-28 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 1:48 [PATCH v2 0/9] Add new helper to allocate IRQ domain for host drivers Shawn Lin
2018-04-28 1:48 ` [PATCH v2 1/9] PCI: Add pci_alloc_intx_irqd() for allocating IRQ domain Shawn Lin
2018-04-28 17:59 ` Christoph Hellwig [this message]
2018-04-29 21:56 ` kbuild test robot
2018-04-30 0:23 ` kbuild test robot
2018-04-28 1:49 ` [PATCH v2 2/9] PCI: dra7xx: Use pci_alloc_intx_irqd() helper to simplify the code Shawn Lin
2018-04-28 1:49 ` [PATCH v2 3/9] PCI: keystone-dw: Use pci_alloc_intx_irqd() helper to get irq domain for INTx Shawn Lin
2018-04-28 1:49 ` [PATCH v2 4/9] PCI: aardvark: " Shawn Lin
2018-04-28 1:49 ` [PATCH v2 5/9] PCI: faraday: " Shawn Lin
2018-04-28 1:50 ` [PATCH v2 6/9] PCI: altera: " Shawn Lin
2018-04-28 1:50 ` [PATCH v2 7/9] PCI: mediatek: " Shawn Lin
2018-04-28 1:50 ` [PATCH v2 8/9] PCI: xilinx-nwl: " Shawn Lin
2018-04-28 1:50 ` [PATCH v2 9/9] PCI: xilinx: " Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428175925.GA17528@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).