Re: [PATCH 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting

[Shawn Guo <shawn.guo@linaro.org>]

On Wed, May 09, 2018 at 09:29:25AM +0200, Thomas Petazzoni wrote:
> Hello Shawn,
> 
> On Wed,  9 May 2018 13:39:41 +0800, Shawn Guo wrote:
> > The root_bus_nr initialization has already been done in function
> > dw_pcie_host_init().
> 
> The formulation "has already been done" makes me think it's been done
> *before* pp->root_bus_nr = -1, which is not what happens. I believe a
> better formulation here would be:
> 
> dw_pcie_host_init() already initializes the root_bus_nr field of
> 'struct pcie_port', so there is no need to initialize it prior to
> calling dw_pcie_host_init().

Yes, this is better.  I will improve the commit log as suggested.
Thanks.

> 
> >  The -1 assignment in platform driver before
> > calling into dw_pcie_host_init() is not really needed.  Drop it.
> > 
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Other than my comment on the commit log:
> 
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks.

Shawn