From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting
Date: Wed, 9 May 2018 09:29:25 +0200 [thread overview]
Message-ID: <20180509092925.2d2cd2f3@windsurf.home> (raw)
In-Reply-To: <1525844386-5433-4-git-send-email-shawn.guo@linaro.org>
Hello Shawn,
On Wed, 9 May 2018 13:39:41 +0800, Shawn Guo wrote:
> The root_bus_nr initialization has already been done in function
> dw_pcie_host_init().
The formulation "has already been done" makes me think it's been done
*before* pp->root_bus_nr = -1, which is not what happens. I believe a
better formulation here would be:
dw_pcie_host_init() already initializes the root_bus_nr field of
'struct pcie_port', so there is no need to initialize it prior to
calling dw_pcie_host_init().
> The -1 assignment in platform driver before
> calling into dw_pcie_host_init() is not really needed. Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Other than my comment on the commit log:
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-09 7:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
2018-05-09 5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
2018-05-09 5:39 ` [PATCH 3/9] PCI: keystone: " Shawn Guo
2018-05-09 5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
2018-05-09 7:29 ` Thomas Petazzoni [this message]
2018-05-09 7:52 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 5/9] PCI: artpec6: " Shawn Guo
2018-05-09 5:39 ` [PATCH 6/9] PCI: designware-plat: " Shawn Guo
2018-05-09 5:39 ` [PATCH 7/9] PCI: histb: " Shawn Guo
2018-05-09 5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
2018-05-09 15:46 ` Stanimir Varbanov
2018-05-09 5:39 ` [PATCH 9/9] PCI: spear13xx: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509092925.2d2cd2f3@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).