From: Keith Busch <keith.busch@linux.intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Laurence Oberman <loberman@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-pci@vger.kernel.org, James Smart <james.smart@broadcom.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Ming Lei <ming.lei@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
bhelgaas@google.com, arjan@linux.intel.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V6 11/11] nvme: pci: support nested EH
Date: Fri, 18 May 2018 10:28:04 -0600 [thread overview]
Message-ID: <20180518162804.GA27795@localhost.localdomain> (raw)
In-Reply-To: <20180517142345.t6bnyfne7ndgrxkg@linux-x5ow.site>
On Thu, May 17, 2018 at 04:23:45PM +0200, Johannes Thumshirn wrote:
> > Agreed. Alternatively possibly call the driver's reset_preparei/done
> > callbacks.
>
> Exactly, but as long as we can issue the reset via sysfs the test-case
> is still valid.
I disagree the test case is valid. The test writes '0' to the
pci-sysfs 'enable', but the driver also disables the pci device as part
of resetting, which is a perfectly reasonable thing for a driver to do.
If the timing of the test's loop happens to write '0' right after the
driver disabled the device that it owns, a 'write error' on that sysfs
write occurs, and blktests then incorrectly claims the test failed.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2018-05-18 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180516040313.13596-1-ming.lei@redhat.com>
[not found] ` <20180516040313.13596-12-ming.lei@redhat.com>
[not found] ` <20180516141242.GA20119@localhost.localdomain>
[not found] ` <20180516231058.GB28727@ming.t460p>
[not found] ` <20180517022030.GB21959@localhost.localdomain>
2018-05-17 8:41 ` [PATCH V6 11/11] nvme: pci: support nested EH Christoph Hellwig
2018-05-17 14:20 ` Keith Busch
2018-05-17 14:23 ` Johannes Thumshirn
2018-05-18 16:28 ` Keith Busch [this message]
2018-05-22 7:35 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518162804.GA27795@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jianchao.w.wang@oracle.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox