From: Pavel Machek <pavel@ucw.cz>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: bhelgaas@google.com, alex_gagniuc@dellteam.com,
austin_bolen@dell.com, shyam_iyer@dell.com,
keith.busch@intel.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Check for PCIe downtraining conditions
Date: Sat, 2 Jun 2018 19:42:59 +0200 [thread overview]
Message-ID: <20180602174259.GA14870@amd> (raw)
In-Reply-To: <20180531150535.9684-1-mr.nuke.me@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Thu 2018-05-31 10:05:33, Alexandru Gagniuc wrote:
> PCIe downtraining happens when both the device and PCIe port are
> capable of a larger bus width or higher speed than negotiated.
> Downtraining might be indicative of other problems in the system, and
> identifying this from userspace is neither intuitive, nor straigh
> forward.
> Instead, check for such conditions on device probe, and print an
> appropriate message.
>
> + if (dev_cur_width < max_link_width) {
> + /* Lanes might not be routed, so use info instead of warn. */
> + pci_info(dev, "PCIe downtrain: Port and device capable of x%d, but link running at x%d",
> + max_link_width, dev_cur_width);
> + }
Would "warn" be right loglevel?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2018-06-02 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:05 [PATCH] PCI: Check for PCIe downtraining conditions Alexandru Gagniuc
2018-05-31 15:28 ` Sinan Kaya
2018-05-31 15:29 ` Alex_Gagniuc
2018-05-31 15:38 ` Sinan Kaya
2018-05-31 15:46 ` Alex G.
2018-05-31 15:54 ` Sinan Kaya
2018-05-31 16:01 ` Alex G.
2018-05-31 16:13 ` Sinan Kaya
2018-05-31 16:49 ` Alex G.
2018-05-31 16:50 ` Alex G.
2018-05-31 17:11 ` Sinan Kaya
2018-05-31 17:27 ` Alex G.
2018-05-31 21:52 ` Alex G.
2018-05-31 15:30 ` Sinan Kaya
2018-05-31 21:44 ` Alex G.
2018-06-01 13:30 ` Sinan Kaya
2018-06-02 17:42 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602174259.GA14870@amd \
--to=pavel@ucw.cz \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).