From: Michal Hocko <mhocko@kernel.org>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: tnowicki@caviumnetworks.com, xiexiuqi@huawei.com,
linux-pci@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Will Deacon <will.deacon@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-mm@kvack.org, wanghuiqiang@huawei.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] arm64: avoid alloc memory on offline node
Date: Thu, 7 Jun 2018 14:21:52 +0200 [thread overview]
Message-ID: <20180607122152.GP32433@dhcp22.suse.cz> (raw)
In-Reply-To: <5ed798a0-6c9c-086e-e5e8-906f593ca33e@huawei.com>
On Thu 07-06-18 19:55:53, Hanjun Guo wrote:
> On 2018/6/7 18:55, Michal Hocko wrote:
[...]
> > I am not sure I have the full context but pci_acpi_scan_root calls
> > kzalloc_node(sizeof(*info), GFP_KERNEL, node)
> > and that should fall back to whatever node that is online. Offline node
> > shouldn't keep any pages behind. So there must be something else going
> > on here and the patch is not the right way to handle it. What does
> > faddr2line __alloc_pages_nodemask+0xf0 tells on this kernel?
>
> The whole context is:
>
> The system is booted with a NUMA node has no memory attaching to it
> (memory-less NUMA node), also with NR_CPUS less than CPUs presented
> in MADT, so CPUs on this memory-less node are not brought up, and
> this NUMA node will not be online (but SRAT presents this NUMA node);
>
> Devices attaching to this NUMA node such as PCI host bridge still
> return the valid NUMA node via _PXM, but actually that valid NUMA node
> is not online which lead to this issue.
But we should have other numa nodes on the zonelists so the allocator
should fall back to other node. If the zonelist is not intiailized
properly, though, then this can indeed show up as a problem. Knowing
which exact place has blown up would help get a better picture...
--
Michal Hocko
SUSE Labs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-06-07 12:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527768879-88161-1-git-send-email-xiexiuqi@huawei.com>
[not found] ` <1527768879-88161-2-git-send-email-xiexiuqi@huawei.com>
[not found] ` <20180606154516.GL6631@arm.com>
2018-06-06 20:39 ` [PATCH 1/2] arm64: avoid alloc memory on offline node Bjorn Helgaas
2018-06-07 10:55 ` Michal Hocko
2018-06-07 11:55 ` Hanjun Guo
2018-06-07 12:21 ` Michal Hocko [this message]
2018-06-11 3:23 ` Xie XiuQi
2018-06-11 8:52 ` Michal Hocko
2018-06-11 12:32 ` Xie XiuQi
2018-06-11 13:43 ` Bjorn Helgaas
2018-06-11 14:53 ` Michal Hocko
2018-06-12 15:08 ` Punit Agrawal
2018-06-12 15:20 ` Michal Hocko
2018-06-13 17:39 ` Punit Agrawal
2018-06-14 6:23 ` Hanjun Guo
2018-06-19 12:03 ` Xie XiuQi
2018-06-19 12:07 ` Michal Hocko
2018-06-19 12:40 ` Xie XiuQi
2018-06-19 12:52 ` Punit Agrawal
2018-06-19 14:08 ` Lorenzo Pieralisi
2018-06-19 14:54 ` Punit Agrawal
2018-06-19 15:14 ` Michal Hocko
2018-06-19 15:35 ` Punit Agrawal
2018-06-19 16:32 ` Lorenzo Pieralisi
2018-06-20 3:31 ` Xie XiuQi
2018-06-20 11:51 ` Punit Agrawal
2018-06-22 8:58 ` Hanjun Guo
2018-06-22 9:11 ` Michal Hocko
2018-06-22 10:24 ` Punit Agrawal
2018-06-22 17:42 ` Jonathan Cameron
2018-06-26 17:27 ` Punit Agrawal
2018-06-26 17:27 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607122152.GP32433@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tnowicki@caviumnetworks.com \
--cc=wanghuiqiang@huawei.com \
--cc=will.deacon@arm.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).