* [RFC PATCH pci] PCI/AER: aer_isr() can be static
2018-06-08 15:44 [pci:pci/aer-squash 12/12] drivers/pci/pcie/aer.c:1038:6: sparse: symbol 'aer_isr' was not declared. Should it be static? kbuild test robot
@ 2018-06-08 15:44 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-06-08 15:44 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: kbuild-all, linux-pci
Fixes: 8079c81ec306 ("PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index d84cc11..a2e8838 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -1035,7 +1035,7 @@ static int get_e_source(struct aer_rpc *rpc, struct aer_err_source *e_src)
*
* Invoked, as DPC, when root port records new detected error
*/
-void aer_isr(struct work_struct *work)
+static void aer_isr(struct work_struct *work)
{
struct aer_rpc *rpc = container_of(work, struct aer_rpc, dpc_handler);
struct aer_err_source uninitialized_var(e_src);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [pci:pci/aer-squash 12/12] drivers/pci/pcie/aer.c:1038:6: sparse: symbol 'aer_isr' was not declared. Should it be static?
@ 2018-06-08 15:44 kbuild test robot
2018-06-08 15:44 ` [RFC PATCH pci] PCI/AER: aer_isr() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-06-08 15:44 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: kbuild-all, linux-pci
Hi Bjorn,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/aer-squash
head: 8079c81ec30626bea7c07c1e4b814efbe3d81044
commit: 8079c81ec30626bea7c07c1e4b814efbe3d81044 [12/12] PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/
reproduce:
# apt-get install sparse
git checkout 8079c81ec30626bea7c07c1e4b814efbe3d81044
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/pcie/aer.c:1038:6: sparse: symbol 'aer_isr' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-08 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08 15:44 [pci:pci/aer-squash 12/12] drivers/pci/pcie/aer.c:1038:6: sparse: symbol 'aer_isr' was not declared. Should it be static? kbuild test robot
2018-06-08 15:44 ` [RFC PATCH pci] PCI/AER: aer_isr() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).