From: Keith Busch <keith.busch@intel.com>
To: poza@codeaurora.org
Cc: Sinan Kaya <okaya@codeaurora.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI/AER: Prevent runtime power management during recovery
Date: Tue, 12 Jun 2018 08:44:44 -0600 [thread overview]
Message-ID: <20180612144443.GA3142@localhost.localdomain> (raw)
In-Reply-To: <76f700a5484d82529272d94b4531e434@codeaurora.org>
On Tue, Jun 12, 2018 at 01:21:53PM +0530, poza@codeaurora.org wrote:
> On 2018-06-12 10:10, Sinan Kaya wrote:
> > On 6/11/2018 6:29 PM, Keith Busch wrote:
> > > A bridge that supports D3 but not hotplug will be subject to runtime
> > > power management placing it in a non-operation power state if it
> > > doesn't
> > > have any devices attached. This patch will prevent this power
> > > management
> > > during error recovery so that the rescan at the end may be successful.
> >
> > If there is no card connected, why would the bridge observe a fatal
> > error?
>
> fatal error could be coming from anywhere let us say below RootPort..
> and RP observes it and decides to take the tree down....
> Is that the case Keith is talking about ?
Right, the err fatal handling removes all the devices below a bridge,
making that bridge allowed for run time d3.
> Why will re-enumeration be a problem even if runtime PM is active ?
> I assume that enumeration will get bridge out of D3.
That doesn't seem to be the case.
next prev parent reply other threads:[~2018-06-12 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 22:29 [PATCH] PCI/AER: Prevent runtime power management during recovery Keith Busch
2018-06-12 4:40 ` Sinan Kaya
2018-06-12 7:51 ` poza
2018-06-12 14:44 ` Keith Busch [this message]
2018-06-12 15:16 ` poza
2018-06-30 19:58 ` Bjorn Helgaas
2018-07-01 11:51 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612144443.GA3142@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).