From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: bhelgaas@google.com, keith.busch@intel.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Frederick Lawler <fred@fredlawl.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3] PCI/AER: Fix aerdrv loading with "pcie_ports=native" parameter
Date: Mon, 2 Jul 2018 11:16:01 -0500 [thread overview]
Message-ID: <20180702161611.2048-1-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20180702131923.GB15983@bhelgaas-glaptop.roam.corp.google.com>
According to the documentation, "pcie_ports=native", linux should use
native AER and DPC services. While that is true for the _OSC method
parsing, this is not the only place that is checked. Should the HEST
table list PCIe ports as firmware-first, linux will not use native
services.
This happens because aer_acpi_firmware_first() doesn't take
'pcie_ports' into account. This is wrong. DPC uses the same logic when
it decides whether to load or not, so fixing this also fixes DPC not
loading.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
drivers/pci/pcie/aer.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index a2e88386af28..db2c01056dc7 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -283,13 +283,14 @@ static int aer_hest_parse(struct acpi_hest_header *hest_hdr, void *data)
static void aer_set_firmware_first(struct pci_dev *pci_dev)
{
- int rc;
+ int rc = 0;
struct aer_hest_parse_info info = {
.pci_dev = pci_dev,
.firmware_first = 0,
};
- rc = apei_hest_parse(aer_hest_parse, &info);
+ if (!pcie_ports_native)
+ rc = apei_hest_parse(aer_hest_parse, &info);
if (rc)
pci_dev->__aer_firmware_first = 0;
@@ -324,7 +325,9 @@ bool aer_acpi_firmware_first(void)
};
if (!parsed) {
- apei_hest_parse(aer_hest_parse, &info);
+ if (!pcie_ports_native)
+ apei_hest_parse(aer_hest_parse, &info);
+
aer_firmware_first = info.firmware_first;
parsed = true;
}
--
2.14.3
next prev parent reply other threads:[~2018-07-02 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:58 [PATCH v2] PCI/AER: Fix aerdrv loading with "pcie_ports=native" parameter Alexandru Gagniuc
2018-06-30 21:31 ` Bjorn Helgaas
2018-07-01 4:39 ` Alex G
2018-07-02 13:16 ` Bjorn Helgaas
2018-07-02 14:52 ` Alex G.
2018-07-02 13:19 ` Bjorn Helgaas
2018-07-02 16:16 ` Alexandru Gagniuc [this message]
2018-07-03 16:38 ` [PATCH v3] " Bjorn Helgaas
2018-07-03 17:13 ` Alex G.
2018-07-03 23:27 ` [PATCH v4] " Alexandru Gagniuc
2018-07-10 23:19 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702161611.2048-1-mr.nuke.me@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=poza@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).