From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Shawn Guo <shawn.guo@linaro.org>, Jingoo Han <jingoohan1@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Jianguo Sun <sunjianguo1@huawei.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting
Date: Wed, 4 Jul 2018 17:21:14 +0100 [thread overview]
Message-ID: <20180704162114.GC12996@red-moon> (raw)
In-Reply-To: <1530417291-30495-2-git-send-email-shawn.guo@linaro.org>
On Sun, Jul 01, 2018 at 11:54:43AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---
> drivers/pci/controller/dwc/pci-exynos.c | 1 -
> 1 file changed, 1 deletion(-)
Jingoo we would need your ACK here, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
> index 4cc1e5df8c79..cee5f2f590e2 100644
> --- a/drivers/pci/controller/dwc/pci-exynos.c
> +++ b/drivers/pci/controller/dwc/pci-exynos.c
> @@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
> }
> }
>
> - pp->root_bus_nr = -1;
> pp->ops = &exynos_pcie_host_ops;
>
> ret = dw_pcie_host_init(pp);
> --
> 1.9.1
>
next prev parent reply other threads:[~2018-07-04 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 3:54 [PATCH v3 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting Shawn Guo
2018-07-01 3:54 ` [PATCH v3 1/9] PCI: exynos: " Shawn Guo
2018-07-04 16:21 ` Lorenzo Pieralisi [this message]
2018-07-05 19:40 ` Jingoo Han
2018-07-06 9:20 ` Lorenzo Pieralisi
2018-07-01 3:54 ` [PATCH v3 2/9] PCI: imx6: " Shawn Guo
2018-07-02 10:25 ` Lucas Stach
2018-07-01 3:54 ` [PATCH v3 3/9] PCI: keystone: " Shawn Guo
2018-07-04 16:23 ` Lorenzo Pieralisi
2018-07-01 3:54 ` [PATCH v3 4/9] PCI: armada8k: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 5/9] PCI: artpec6: " Shawn Guo
2018-07-02 8:47 ` Jesper Nilsson
2018-07-01 3:54 ` [PATCH v3 6/9] PCI: designware-plat: " Shawn Guo
2018-07-02 8:38 ` Gustavo Pimentel
2018-07-01 3:54 ` [PATCH v3 7/9] PCI: histb: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 8/9] PCI: qcom: " Shawn Guo
2018-07-01 3:54 ` [PATCH v3 9/9] PCI: spear13xx: " Shawn Guo
2018-07-13 13:20 ` [PATCH v3 0/9] PCI: dwc: " Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704162114.GC12996@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=sunjianguo1@huawei.com \
--cc=svarbanov@mm-sol.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).