[PATCH v3 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[PATCH v3 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Shawn Guo]

The designware core function dw_pcie_host_init() already initializes
the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior
to calling dw_pcie_host_init() in platform specific driver is not really
needed.  Drop it.

Changes for v3:
 - Rebase to v4.18-rc1
 - Collect ACK from Pratyush on spear13xx driver

Changes for v2:
 - Improve commit log a bit per Thomas' suggestion.
 - Collect ACK from Thomas and Stanimir on armada8k and qcom driver.


Shawn Guo (9):
  PCI: exynos: Drop unnecessary root_bus_nr setting
  PCI: imx6: Drop unnecessary root_bus_nr setting
  PCI: keystone: Drop unnecessary root_bus_nr setting
  PCI: armada8k: Drop unnecessary root_bus_nr setting
  PCI: artpec6: Drop unnecessary root_bus_nr setting
  PCI: designware-plat: Drop unnecessary root_bus_nr setting
  PCI: histb: Drop unnecessary root_bus_nr setting
  PCI: qcom: Drop unnecessary root_bus_nr setting
  PCI: spear13xx: Drop unnecessary root_bus_nr setting

 drivers/pci/controller/dwc/pci-exynos.c           | 1 -
 drivers/pci/controller/dwc/pci-imx6.c             | 1 -
 drivers/pci/controller/dwc/pci-keystone.c         | 1 -
 drivers/pci/controller/dwc/pcie-armada8k.c        | 1 -
 drivers/pci/controller/dwc/pcie-artpec6.c         | 1 -
 drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
 drivers/pci/controller/dwc/pcie-histb.c           | 1 -
 drivers/pci/controller/dwc/pcie-qcom.c            | 1 -
 drivers/pci/controller/dwc/pcie-spear13xx.c       | 1 -
 9 files changed, 9 deletions(-)

-- 
1.9.1

[PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
---
 drivers/pci/controller/dwc/pci-exynos.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 4cc1e5df8c79..cee5f2f590e2 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &exynos_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Sun, Jul 01, 2018 at 11:54:43AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---
>  drivers/pci/controller/dwc/pci-exynos.c | 1 -
>  1 file changed, 1 deletion(-)

Jingoo we would need your ACK here, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
> index 4cc1e5df8c79..cee5f2f590e2 100644
> --- a/drivers/pci/controller/dwc/pci-exynos.c
> +++ b/drivers/pci/controller/dwc/pci-exynos.c
> @@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
>  		}
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &exynos_pcie_host_ops;
>  
>  	ret = dw_pcie_host_init(pp);
> -- 
> 1.9.1
> 

Re: [PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

[Jingoo Han]

On Wednesday, July 4, 2018 12:21 PM, Lorenzo Pieralisi wrote:
> 
> On Sun, Jul 01, 2018 at 11:54:43AM +0800, Shawn Guo wrote:
> > Function dw_pcie_host_init() already initializes the root_bus_nr field
> > of 'struct pcie_port', so the -1 assignment prior to calling
> > dw_pcie_host_init() in platform specific driver is not really needed.
> > Drop it.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Jingoo Han <jingoohan1@gmail.com>
> > ---
> >  drivers/pci/controller/dwc/pci-exynos.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Jingoo we would need your ACK here, thanks.

I am not sure that this patch is good.
Currently, this patch does not make any problem.
However, I prefer to keep checking codes unless it makes a lot of burden.
This is because we cannot ensure that flow of codes will not change in the
future.
However, if you think that it can be ensured that the problem will not
happen
in the future, please merge this patch.

Best regards,
Jingoo Han

> 
> Lorenzo
> 
> > diff --git a/drivers/pci/controller/dwc/pci-exynos.c
> b/drivers/pci/controller/dwc/pci-exynos.c
> > index 4cc1e5df8c79..cee5f2f590e2 100644
> > --- a/drivers/pci/controller/dwc/pci-exynos.c
> > +++ b/drivers/pci/controller/dwc/pci-exynos.c
> > @@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct
> exynos_pcie *ep,
> >  		}
> >  	}
> >
> > -	pp->root_bus_nr = -1;
> >  	pp->ops = &exynos_pcie_host_ops;
> >
> >  	ret = dw_pcie_host_init(pp);
> > --
> > 1.9.1
> >

Re: [PATCH v3 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Thu, Jul 05, 2018 at 03:40:35PM -0400, Jingoo Han wrote:
> On Wednesday, July 4, 2018 12:21 PM, Lorenzo Pieralisi wrote:
> > 
> > On Sun, Jul 01, 2018 at 11:54:43AM +0800, Shawn Guo wrote:
> > > Function dw_pcie_host_init() already initializes the root_bus_nr field
> > > of 'struct pcie_port', so the -1 assignment prior to calling
> > > dw_pcie_host_init() in platform specific driver is not really needed.
> > > Drop it.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Jingoo Han <jingoohan1@gmail.com>
> > > ---
> > >  drivers/pci/controller/dwc/pci-exynos.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > 
> > Jingoo we would need your ACK here, thanks.
> 
> I am not sure that this patch is good.
> Currently, this patch does not make any problem.  However, I prefer to
> keep checking codes unless it makes a lot of burden.  This is because
> we cannot ensure that flow of codes will not change in the future.

If the call flow changes in the future we will have to make changes
anyway since there are bits and pieces of struct pcie_port that are
initialized in dw_pcie_host_init(). Maybe I do not understand your
concern, for the time being Shawn is removing useless code AFAICS.

Lorenzo

> However, if you think that it can be ensured that the problem will not
> happen in the future, please merge this patch.
> 
> Best regards,
> Jingoo Han
> 
> > 
> > Lorenzo
> > 
> > > diff --git a/drivers/pci/controller/dwc/pci-exynos.c
> > b/drivers/pci/controller/dwc/pci-exynos.c
> > > index 4cc1e5df8c79..cee5f2f590e2 100644
> > > --- a/drivers/pci/controller/dwc/pci-exynos.c
> > > +++ b/drivers/pci/controller/dwc/pci-exynos.c
> > > @@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct
> > exynos_pcie *ep,
> > >  		}
> > >  	}
> > >
> > > -	pp->root_bus_nr = -1;
> > >  	pp->ops = &exynos_pcie_host_ops;
> > >
> > >  	ret = dw_pcie_host_init(pp);
> > > --
> > > 1.9.1
> > >
> 

[PATCH v3 2/9] PCI: imx6: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pci/controller/dwc/pci-imx6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 80f604602783..4a9a673b4777 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -667,7 +667,6 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &imx6_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v3 2/9] PCI: imx6: Drop unnecessary root_bus_nr setting

[Lucas Stach]

Am Sonntag, den 01.07.2018, 11:54 +0800 schrieb Shawn Guo:
> Function dw_pcie_host_init() already initializes the root_bus_nr
> field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 80f604602783..4a9a673b4777 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -667,7 +667,6 @@ static int imx6_add_pcie_port(struct imx6_pcie
> *imx6_pcie,
>  		}
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &imx6_pcie_host_ops;
>  
>  	ret = dw_pcie_host_init(pp);

[PATCH v3 3/9] PCI: keystone: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/pci/controller/dwc/pci-keystone.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 3722a5f31e5e..e88bd221fffe 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &keystone_pcie_host_ops;
 	ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
 	if (ret) {
-- 
1.9.1

Re: [PATCH v3 3/9] PCI: keystone: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Sun, Jul 01, 2018 at 11:54:45AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> ---
>  drivers/pci/controller/dwc/pci-keystone.c | 1 -
>  1 file changed, 1 deletion(-)

Hi Murali,

we would need your ACK to send this series upstream, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index 3722a5f31e5e..e88bd221fffe 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
>  		}
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &keystone_pcie_host_ops;
>  	ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
>  	if (ret) {
> -- 
> 1.9.1
> 

[PATCH v3 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 drivers/pci/controller/dwc/pcie-armada8k.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-armada8k.c b/drivers/pci/controller/dwc/pcie-armada8k.c
index 072fd7ecc29f..0c389a30ef5d 100644
--- a/drivers/pci/controller/dwc/pcie-armada8k.c
+++ b/drivers/pci/controller/dwc/pcie-armada8k.c
@@ -172,7 +172,6 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
 	struct device *dev = &pdev->dev;
 	int ret;
 
-	pp->root_bus_nr = -1;
 	pp->ops = &armada8k_pcie_host_ops;
 
 	pp->irq = platform_get_irq(pdev, 0);
-- 
1.9.1

[PATCH v3 5/9] PCI: artpec6: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
---
 drivers/pci/controller/dwc/pcie-artpec6.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
index 321b56cfd5d0..128b182648b3 100644
--- a/drivers/pci/controller/dwc/pcie-artpec6.c
+++ b/drivers/pci/controller/dwc/pcie-artpec6.c
@@ -399,7 +399,6 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &artpec6_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v3 5/9] PCI: artpec6: Drop unnecessary root_bus_nr setting

[Jesper Nilsson]

On Sun, Jul 01, 2018 at 11:54:47AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

> ---
>  drivers/pci/controller/dwc/pcie-artpec6.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
> index 321b56cfd5d0..128b182648b3 100644
> --- a/drivers/pci/controller/dwc/pcie-artpec6.c
> +++ b/drivers/pci/controller/dwc/pcie-artpec6.c
> @@ -399,7 +399,6 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
>  		}
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &artpec6_pcie_host_ops;
>  
>  	ret = dw_pcie_host_init(pp);
> -- 
> 1.9.1

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

[PATCH v3 6/9] PCI: designware-plat: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>
---
 drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
index 5937fed4c938..6e048c0b67f2 100644
--- a/drivers/pci/controller/dwc/pcie-designware-plat.c
+++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
@@ -118,7 +118,6 @@ static int dw_plat_add_pcie_port(struct dw_plat_pcie *dw_plat_pcie,
 			return pp->msi_irq;
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &dw_plat_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v3 6/9] PCI: designware-plat: Drop unnecessary root_bus_nr setting

[Gustavo Pimentel]

Hi Shawn,

On 01/07/2018 04:54, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Joao Pinto <Joao.Pinto@synopsys.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> index 5937fed4c938..6e048c0b67f2 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> @@ -118,7 +118,6 @@ static int dw_plat_add_pcie_port(struct dw_plat_pcie *dw_plat_pcie,
>  			return pp->msi_irq;
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &dw_plat_pcie_host_ops;
>  
>  	ret = dw_pcie_host_init(pp);
> 

Looks good :)
Thanks

Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>

Regards,
Gustavo

[PATCH v3 7/9] PCI: histb: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jianguo Sun <sunjianguo1@huawei.com>
---
 drivers/pci/controller/dwc/pcie-histb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
index 3611d6ce9a92..7b32e619b959 100644
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -420,7 +420,6 @@ static int histb_pcie_probe(struct platform_device *pdev)
 		phy_init(hipcie->phy);
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &histb_pcie_host_ops;
 
 	platform_set_drvdata(pdev, hipcie);
-- 
1.9.1

[PATCH v3 8/9] PCI: qcom: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index a1d0198081a6..4352c1cb926d 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1251,7 +1251,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	pp->root_bus_nr = -1;
 	pp->ops = &qcom_pcie_dw_ops;
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
-- 
1.9.1

[PATCH v3 9/9] PCI: spear13xx: Drop unnecessary root_bus_nr setting

[Shawn Guo]

Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Pratyush Anand <pratyush.anand@gmail.com>
---
 drivers/pci/controller/dwc/pcie-spear13xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-spear13xx.c b/drivers/pci/controller/dwc/pcie-spear13xx.c
index ecb58f7b7566..7d0cdfd8138b 100644
--- a/drivers/pci/controller/dwc/pcie-spear13xx.c
+++ b/drivers/pci/controller/dwc/pcie-spear13xx.c
@@ -210,7 +210,6 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
 		return ret;
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &spear13xx_pcie_host_ops;
 
 	ret = dw_pcie_host_init(pp);
-- 
1.9.1

Re: [PATCH v3 0/9] PCI: dwc: Drop unnecessary root_bus_nr setting

[Lorenzo Pieralisi]

On Sun, Jul 01, 2018 at 11:54:42AM +0800, Shawn Guo wrote:
> The designware core function dw_pcie_host_init() already initializes
> the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior
> to calling dw_pcie_host_init() in platform specific driver is not really
> needed.  Drop it.
> 
> Changes for v3:
>  - Rebase to v4.18-rc1
>  - Collect ACK from Pratyush on spear13xx driver
> 
> Changes for v2:
>  - Improve commit log a bit per Thomas' suggestion.
>  - Collect ACK from Thomas and Stanimir on armada8k and qcom driver.
> 
> 
> Shawn Guo (9):
>   PCI: exynos: Drop unnecessary root_bus_nr setting
>   PCI: imx6: Drop unnecessary root_bus_nr setting
>   PCI: keystone: Drop unnecessary root_bus_nr setting
>   PCI: armada8k: Drop unnecessary root_bus_nr setting
>   PCI: artpec6: Drop unnecessary root_bus_nr setting
>   PCI: designware-plat: Drop unnecessary root_bus_nr setting
>   PCI: histb: Drop unnecessary root_bus_nr setting
>   PCI: qcom: Drop unnecessary root_bus_nr setting
>   PCI: spear13xx: Drop unnecessary root_bus_nr setting
> 
>  drivers/pci/controller/dwc/pci-exynos.c           | 1 -
>  drivers/pci/controller/dwc/pci-imx6.c             | 1 -
>  drivers/pci/controller/dwc/pci-keystone.c         | 1 -
>  drivers/pci/controller/dwc/pcie-armada8k.c        | 1 -
>  drivers/pci/controller/dwc/pcie-artpec6.c         | 1 -
>  drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
>  drivers/pci/controller/dwc/pcie-histb.c           | 1 -
>  drivers/pci/controller/dwc/pcie-qcom.c            | 1 -
>  drivers/pci/controller/dwc/pcie-spear13xx.c       | 1 -
>  9 files changed, 9 deletions(-)

Applied to pci/dwc for v4.19, thanks.

Lorenzo