From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:35936 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730601AbeGMO2G (ORCPT ); Fri, 13 Jul 2018 10:28:06 -0400 Date: Fri, 13 Jul 2018 15:15:11 +0100 From: Lorenzo Pieralisi To: Colin King Cc: Alan Douglas , Bjorn Helgaas , linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: pcie-candence-ep: remove redundant variable mmc Message-ID: <20180713141511.GA18555@red-moon> References: <20180711080103.4581-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180711080103.4581-1-colin.king@canonical.com> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Jul 11, 2018 at 09:01:03AM +0100, Colin King wrote: > From: Colin Ian King > > Variable mmc is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'mmc' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/pci/controller/pcie-cadence-ep.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to pci/cadence for v4.19, thanks. Lorenzo > diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c > index e3fe4124e3af..63549e03eae8 100644 > --- a/drivers/pci/controller/pcie-cadence-ep.c > +++ b/drivers/pci/controller/pcie-cadence-ep.c > @@ -238,7 +238,7 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > struct cdns_pcie_ep *ep = epc_get_drvdata(epc); > struct cdns_pcie *pcie = &ep->pcie; > u32 cap = CDNS_PCIE_EP_FUNC_MSI_CAP_OFFSET; > - u16 flags, mmc, mme; > + u16 flags, mme; > > /* Validate that the MSI feature is actually enabled. */ > flags = cdns_pcie_ep_fn_readw(pcie, fn, cap + PCI_MSI_FLAGS); > @@ -249,7 +249,6 @@ static int cdns_pcie_ep_get_msi(struct pci_epc *epc, u8 fn) > * Get the Multiple Message Enable bitfield from the Message Control > * register. > */ > - mmc = (flags & PCI_MSI_FLAGS_QMASK) >> 1; > mme = (flags & PCI_MSI_FLAGS_QSIZE) >> 4; > > return mme; > -- > 2.17.1 >