From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: bhelgaas@google.com, keith.busch@intel.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Frederick Lawler <fred@fredlawl.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER
Date: Tue, 17 Jul 2018 10:31:23 -0500 [thread overview]
Message-ID: <20180717153135.25925-1-mr.nuke.me@gmail.com> (raw)
When we don't own AER, we shouldn't touch the AER error bits. This
happens unconditionally on device probe(). Clearing AER bits
willy-nilly might cause firmware to miss errors. Instead
these bits should get cleared by FFS, or via ACPI _HPX method.
This race is mostly of theoretical significance, as it is not easy to
reasonably demonstrate it in testing.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
drivers/pci/pcie/aer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index a2e88386af28..18037a2a8231 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -383,6 +383,9 @@ int pci_cleanup_aer_error_status_regs(struct pci_dev *dev)
if (!pci_is_pcie(dev))
return -ENODEV;
+ if (pcie_aer_get_firmware_first(dev))
+ return -EIO;
+
pos = dev->aer_cap;
if (!pos)
return -EIO;
--
2.14.3
next reply other threads:[~2018-07-17 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:31 Alexandru Gagniuc [this message]
2018-07-17 15:41 ` [PATCH] PCI/AER: Do not clear AER bits if we don't own AER Sinan Kaya
2018-07-19 15:55 ` Alex G.
2018-07-19 16:58 ` Sinan Kaya
2018-07-19 19:56 ` Alex G.
2018-07-23 16:52 ` [PATCH v2] " Alexandru Gagniuc
2018-07-24 15:59 ` Alex G.
2018-07-30 23:35 ` [PATCH v3] " Alexandru Gagniuc
2018-08-08 1:14 ` Bjorn Helgaas
2018-08-08 3:46 ` Alex G.
2018-07-24 17:08 ` [PATCH v2] " kbuild test robot
2018-07-25 1:03 ` kbuild test robot
2018-08-09 14:15 ` [PATCH] " Bjorn Helgaas
2018-08-09 16:46 ` Alex_Gagniuc
2018-08-09 18:29 ` Bjorn Helgaas
2018-08-09 19:00 ` Alex G.
2018-08-09 19:18 ` Bjorn Helgaas
2018-08-09 19:42 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717153135.25925-1-mr.nuke.me@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=poza@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).