From: kbuild test robot <fengguang.wu@intel.com>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: kbuild-all@01.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: [PATCH] PCI/AER: fix boolreturn.cocci warnings
Date: Fri, 20 Jul 2018 07:54:17 +0800 [thread overview]
Message-ID: <20180719235417.GA7720@athens> (raw)
In-Reply-To: <201807200714.M8pIgh8M%fengguang.wu@intel.com>
From: kbuild test robot <fengguang.wu@intel.com>
drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 69c7f453d545 ("PCI/AER: Honor "pcie_ports=native" even if HEST sets FIRMWARE_FIRST")
CC: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -346,7 +346,7 @@ bool aer_acpi_firmware_first(void)
};
if (pcie_ports_native)
- return 0;
+ return false;
if (!parsed) {
apei_hest_parse(aer_hest_parse, &info);
next prev parent reply other threads:[~2018-07-19 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 23:54 [pci:pci/aer 7/14] drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool kbuild test robot
2018-07-19 23:54 ` kbuild test robot [this message]
2018-07-20 20:30 ` [PATCH] PCI/AER: fix boolreturn.cocci warnings Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719235417.GA7720@athens \
--to=fengguang.wu@intel.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).