* [pci:pci/aer 7/14] drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool
@ 2018-07-19 23:54 kbuild test robot
2018-07-19 23:54 ` [PATCH] PCI/AER: fix boolreturn.cocci warnings kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-07-19 23:54 UTC (permalink / raw)
To: Alexandru Gagniuc; +Cc: kbuild-all, linux-pci, Bjorn Helgaas
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/aer
head: 8138a743c2b056d86d0643670765da11fa9bed17
commit: 69c7f453d545930c8cc60478c27be5e06581ba4b [7/14] PCI/AER: Honor "pcie_ports=native" even if HEST sets FIRMWARE_FIRST
coccinelle warnings: (new ones prefixed by >>)
>> drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] PCI/AER: fix boolreturn.cocci warnings
2018-07-19 23:54 [pci:pci/aer 7/14] drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool kbuild test robot
@ 2018-07-19 23:54 ` kbuild test robot
2018-07-20 20:30 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-07-19 23:54 UTC (permalink / raw)
To: Alexandru Gagniuc; +Cc: kbuild-all, linux-pci, Bjorn Helgaas
From: kbuild test robot <fengguang.wu@intel.com>
drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 69c7f453d545 ("PCI/AER: Honor "pcie_ports=native" even if HEST sets FIRMWARE_FIRST")
CC: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
aer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -346,7 +346,7 @@ bool aer_acpi_firmware_first(void)
};
if (pcie_ports_native)
- return 0;
+ return false;
if (!parsed) {
apei_hest_parse(aer_hest_parse, &info);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI/AER: fix boolreturn.cocci warnings
2018-07-19 23:54 ` [PATCH] PCI/AER: fix boolreturn.cocci warnings kbuild test robot
@ 2018-07-20 20:30 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2018-07-20 20:30 UTC (permalink / raw)
To: kbuild test robot; +Cc: Alexandru Gagniuc, kbuild-all, linux-pci
On Fri, Jul 20, 2018 at 07:54:17AM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 69c7f453d545 ("PCI/AER: Honor "pcie_ports=native" even if HEST sets FIRMWARE_FIRST")
> CC: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
I folded this into the original patch.
> ---
>
> aer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -346,7 +346,7 @@ bool aer_acpi_firmware_first(void)
> };
>
> if (pcie_ports_native)
> - return 0;
> + return false;
>
> if (!parsed) {
> apei_hest_parse(aer_hest_parse, &info);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-20 21:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 23:54 [pci:pci/aer 7/14] drivers/pci/pcie/aer.c:349:9-10: WARNING: return of 0/1 in function 'aer_acpi_firmware_first' with return type bool kbuild test robot
2018-07-19 23:54 ` [PATCH] PCI/AER: fix boolreturn.cocci warnings kbuild test robot
2018-07-20 20:30 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).