From: Lukas Wunner <lukas@wunner.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "Alex_Gagniuc@Dellteam.com" <Alex_Gagniuc@Dellteam.com>,
"mr.nuke.me@gmail.com" <mr.nuke.me@gmail.com>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Austin.Bolen@dell.com" <Austin.Bolen@dell.com>,
"Stuart.Hayes@dell.com" <Stuart.Hayes@dell.com>,
"Narendra.K@dell.com" <Narendra.K@dell.com>,
"Christopher.Arzola@dell.com" <Christopher.Arzola@dell.com>,
"David.Chalfant@dell.com" <David.Chalfant@dell.com>,
Sinan Kaya <okaya@kernel.org>
Subject: Re: Should a PCIe Link Down event set the PCI_DEV_DISCONNECTED bit?
Date: Mon, 30 Jul 2018 15:54:21 +0200 [thread overview]
Message-ID: <20180730135421.GA2680@wunner.de> (raw)
In-Reply-To: <11e48a8d8e144259b4d0fb073c6899c7@AcuMS.aculab.com>
On Mon, Jul 30, 2018 at 01:28:14PM +0000, David Laight wrote:
> From: Lukas Wunner
> > Sent: 28 July 2018 19:32
> ...
> > Finally, if the card was quickly swapped and the link to the new
> > card is already up, you may be accessing that new card. (mmio
> > accesses may then still return all ones if the BARs are blank,
> > but at least config space accesses should work.)
>
> On my i7-7700 system that no longer works (at least with some cards).
> If I take the PCIe link down completely (reset the FPGA on the card)
> it doesn't recover (loops through detect active/quiet and a third
> state I can't quite remember).
>
> ISTR that it recovers from the link going down when I short out
> the PCIe data lines.
>
> It worked fine on a XEON E5-2609 system - I did it a lot when
> updating the fpga image.
>
> Can anyone else verify whether this works on other systems?
> Or whether the kernel (or BIOS) needs to (re-)initialise
> some register to make link recovery work.
Huh? Can you be a bit more specific what exactly no longer works
and which branch or kernel version introduced the regression?
Thanks,
Lukas
next prev parent reply other threads:[~2018-07-30 15:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 22:38 Should a PCIe Link Down event set the PCI_DEV_DISCONNECTED bit? Alex G.
2018-07-26 23:00 ` Rajat Jain
2018-07-27 0:04 ` Alex_Gagniuc
2018-07-27 7:18 ` Lukas Wunner
2018-07-27 15:52 ` Alex_Gagniuc
2018-07-27 17:05 ` Lukas Wunner
2018-07-27 17:51 ` Alex_Gagniuc
2018-07-27 18:17 ` Sinan Kaya
2018-07-27 18:23 ` Alex_Gagniuc
2018-07-27 18:34 ` Sinan Kaya
2018-07-28 18:31 ` Lukas Wunner
2018-07-29 0:26 ` Sinan Kaya
2018-07-29 12:09 ` Lukas Wunner
2018-07-29 16:59 ` Sinan Kaya
2018-07-30 13:28 ` David Laight
2018-07-30 13:54 ` Lukas Wunner [this message]
2018-07-30 16:06 ` David Laight
2018-07-30 21:38 ` Alex_Gagniuc
2018-07-31 9:28 ` Lukas Wunner
2018-07-31 16:35 ` Alex_Gagniuc
2018-08-01 8:58 ` David Laight
2018-08-01 19:06 ` Alex_Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730135421.GA2680@wunner.de \
--to=lukas@wunner.de \
--cc=Alex_Gagniuc@Dellteam.com \
--cc=Austin.Bolen@dell.com \
--cc=Christopher.Arzola@dell.com \
--cc=David.Chalfant@dell.com \
--cc=David.Laight@ACULAB.COM \
--cc=Narendra.K@dell.com \
--cc=Stuart.Hayes@dell.com \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).