From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>, Sinan Kaya <okaya@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: pciehp: Deduplicate presence check on probe & resume
Date: Tue, 31 Jul 2018 23:22:53 +0200 [thread overview]
Message-ID: <20180731212253.GA26620@wunner.de> (raw)
In-Reply-To: <20180731080342.GA2534@lahna.fi.intel.com>
On Tue, Jul 31, 2018 at 11:03:42AM +0300, Mika Westerberg wrote:
> On Sat, Jul 28, 2018 at 07:22:00AM +0200, Lukas Wunner wrote:
> One small nit, see below:
>
> > +/**
> > + * pciehp_check_presence() - synthesize event if presence has changed
>
> You should document the argument as well so that the tool that is used
> to process these knows about it:
>
> @ctrl: ....
Right, I'll fix that up in a follow-up commit since Bjorn has already
pushed this version.
@Bjorn: I've double-checked all the rebased and newly applied patches
on the pci/hotplug branch, looks good. Thanks for adding the reference
to the "Link Status Mapped to the LTSSM" table to the commit message,
and thanks to Sinan for pointing that table out.
Superb job everyone, thanks a lot!
Lukas
next prev parent reply other threads:[~2018-07-31 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 5:22 [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements Lukas Wunner
2018-07-28 5:22 ` [PATCH 2/2] PCI: pciehp: Deduplicate presence check on probe & resume Lukas Wunner
2018-07-31 8:03 ` Mika Westerberg
2018-07-31 21:22 ` Lukas Wunner [this message]
2018-07-31 7:59 ` [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements Mika Westerberg
2018-07-31 15:13 ` Gustavo A. R. Silva
2018-07-31 18:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731212253.GA26620@wunner.de \
--to=lukas@wunner.de \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).