From: Christoph Hellwig <hch@infradead.org>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, rgummal@xilinx.com
Subject: Re: [PATCH 1/3] PCI: xilinx-nwl: Save error IRQ number in device_node private data
Date: Thu, 2 Aug 2018 00:50:51 -0700 [thread overview]
Message-ID: <20180802075051.GA17566@infradead.org> (raw)
In-Reply-To: <1533141889-19962-2-git-send-email-bharat.kumar.gogada@xilinx.com>
> +#ifdef CONFIG_PCIEAER
> + struct device_node *node = dev->of_node;
> +#endif
>
> breg_val = nwl_bridge_readl(pcie, E_BREG_CAPABILITIES) & BREG_PRESENT;
> if (!breg_val) {
> @@ -744,6 +747,9 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
> pcie->irq_misc);
> return err;
> }
> +#ifdef CONFIG_PCIEAER
> + node->data = &pcie->irq_misc;
> +#endif
Is there any good reason for these ifdefs? Always assigning the node
data would seem harmless and much cleaner to me.
next prev parent reply other threads:[~2018-08-02 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 16:44 [PATCH 0/3] Use xilinx controller irq for AER handler Bharat Kumar Gogada
2018-08-01 16:44 ` [PATCH 1/3] PCI: xilinx-nwl: Save error IRQ number in device_node private data Bharat Kumar Gogada
2018-08-02 7:50 ` Christoph Hellwig [this message]
2018-08-01 16:44 ` [PATCH 2/3] PCI: Use dedicated Xilinx controller irq number for AER Bharat Kumar Gogada
2018-08-06 21:03 ` Bjorn Helgaas
2018-08-01 16:44 ` [PATCH 3/3] PCI/portdrv: Add support for sharing xilinx controller irq with AER Bharat Kumar Gogada
2018-08-01 18:05 ` Sinan Kaya
2018-08-06 20:56 ` Bjorn Helgaas
2018-08-06 21:24 ` Sinan Kaya
2018-08-07 13:19 ` Bharat Kumar Gogada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802075051.GA17566@infradead.org \
--to=hch@infradead.org \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rgummal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).