From: Keith Busch <keith.busch@intel.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/VMD: Set up firmware first if capable
Date: Fri, 31 Aug 2018 08:47:21 -0600 [thread overview]
Message-ID: <20180831144721.GA7761@localhost.localdomain> (raw)
In-Reply-To: <1535675403-2903-2-git-send-email-jonathan.derrick@intel.com>
On Thu, Aug 30, 2018 at 06:30:03PM -0600, Jon Derrick wrote:
> Some VMD devices will want to use firmware first error-handling on the
> entire domain. This is detected by the BIOS setting the VMD endpoint's
> interface to 0x1.
>
> Detect this condition and propogate it to the entire domain.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Just curious, do you know what happens if you encounter a fatal error in
a VMD domain with FF enabled? Will this create generic hw error source
event for the OS, and if so, does the error record point to the VMD
device as the source, or the device within the domain that actually
sent the ERR_FATAL?
The implementation looks fine to me.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2018-08-31 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 0:30 [PATCH] VMD firmware first Jon Derrick
2018-08-31 0:30 ` [PATCH] PCI/VMD: Set up firmware first if capable Jon Derrick
2018-08-31 14:47 ` Keith Busch [this message]
2018-09-04 13:08 ` Bjorn Helgaas
2018-09-04 23:04 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831144721.GA7761@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).