From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: bhelgaas@google.com, jgg@ziepe.ca, dledford@redhat.com
Cc: Sinan Kaya <okaya@codeaurora.org>,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: [PATCH for-rc 0/2] IB/hfi1: PCI bug due to pci core changes
Date: Fri, 31 Aug 2018 10:33:54 -0700 [thread overview]
Message-ID: <20180831173132.21741.25892.stgit@scvm10.sc.intel.com> (raw)
Hi Bjorn, Doug and Jason,
As discussed on the pci list [1] our driver was broken with the following three
changes in 4.19 merge window:
c6a44ba950d1 ("PCI: Rename pci_try_reset_bus() to pci_reset_bus()")
409888e0966e ("IB/hfi1: Use pci_try_reset_bus() for initiating PCI Secondary Bus Reset")
811c5cb37df4 ("PCI: Unify try slot and bus reset API")
Ideally I'd like to see those patches reverted but we could also go with
something like the following series. I know there is a desire to have a more
clean API but since this is already the rc phase I think that is best delayed.
Clearly the first attempt at an API clean up did not work out so well.
I'm not sure how you maintainers want to handle this since the fix straddles
both subsystems so I'm sending it to both linux-rdma and linux-pci.
At the request of discussion on the linux-pci list I have also filed a bug [2].
[1] https://marc.info/?l=linux-pci&m=153539692917785&w=2
[2] https://bugzilla.kernel.org/show_bug.cgi?id=200985
Thanks
---
Dennis Dalessandro (2):
PCI: Fix faulty logic in pci_reset_bus()
IB/hfi1,PCI: Allow bus reset while probing
drivers/infiniband/hw/hfi1/pcie.c | 11 ++++-------
drivers/pci/pci.c | 3 ++-
include/linux/pci.h | 3 +++
3 files changed, 9 insertions(+), 8 deletions(-)
--
-Denny
next reply other threads:[~2018-08-31 21:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 17:33 Dennis Dalessandro [this message]
2018-08-31 17:34 ` [PATCH for-rc 1/2] PCI: Fix faulty logic in pci_reset_bus() Dennis Dalessandro
2018-08-31 17:58 ` Sinan Kaya
2018-09-04 20:59 ` Jason Gunthorpe
2018-09-04 21:16 ` Sinan Kaya
2018-09-04 21:30 ` Jason Gunthorpe
2018-09-04 21:50 ` Sinan Kaya
2018-08-31 17:34 ` [PATCH for-rc 2/2] IB/hfi1,PCI: Allow bus reset while probing Dennis Dalessandro
2018-09-12 2:46 ` [PATCH for-rc 0/2] IB/hfi1: PCI bug due to pci core changes Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831173132.21741.25892.stgit@scvm10.sc.intel.com \
--to=dennis.dalessandro@intel.com \
--cc=bhelgaas@google.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).