From: Sinan Kaya <okaya@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Peter Xu <peterx@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Eric Auger <eric.auger@redhat.com>
Subject: [PATCH 3/4] PCI: Expose reset type to users of pci_try_reset_function()
Date: Sat, 8 Sep 2018 04:16:26 +0000 [thread overview]
Message-ID: <20180908041632.22252-3-okaya@kernel.org> (raw)
In-Reply-To: <20180908041632.22252-1-okaya@kernel.org>
Looking to have more control between the users of the API vs. what the API
can do internally. The new reset_type tells the PCI core about the bounds
of the request.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/pci/pci.c | 4 ++--
drivers/vfio/pci/vfio_pci.c | 7 ++++---
drivers/vfio/pci/vfio_pci_config.c | 4 ++--
include/linux/pci.h | 2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 89c45effb4f4..d319a2febe64 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4851,7 +4851,7 @@ EXPORT_SYMBOL_GPL(pci_reset_function_locked);
*
* Same as above, except return -EAGAIN if unable to lock device.
*/
-int pci_try_reset_function(struct pci_dev *dev)
+int pci_try_reset_function(struct pci_dev *dev, u32 reset_type)
{
int rc;
@@ -4862,7 +4862,7 @@ int pci_try_reset_function(struct pci_dev *dev)
return -EAGAIN;
pci_dev_save_and_disable(dev);
- rc = __pci_reset_function_locked(dev, PCI_RESET_ANY);
+ rc = __pci_reset_function_locked(dev, reset_type);
pci_dev_restore(dev);
pci_dev_unlock(dev);
diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index cddb453a1ba5..fe7ada997c51 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -228,7 +228,7 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
return ret;
/* If reset fails because of the device lock, fail this path entirely */
- ret = pci_try_reset_function(pdev);
+ ret = pci_try_reset_function(pdev, PCI_RESET_ANY);
if (ret == -EAGAIN) {
pci_disable_device(pdev);
return ret;
@@ -376,7 +376,7 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev)
* Try to reset the device. The success of this is dependent on
* being able to lock the device, which is not always possible.
*/
- if (vdev->reset_works && !pci_try_reset_function(pdev))
+ if (vdev->reset_works && !pci_try_reset_function(pdev, PCI_RESET_ANY))
vdev->needs_reset = false;
pci_restore_state(pdev);
@@ -844,7 +844,8 @@ static long vfio_pci_ioctl(void *device_data,
} else if (cmd == VFIO_DEVICE_RESET) {
return vdev->reset_works ?
- pci_try_reset_function(vdev->pdev) : -EINVAL;
+ pci_try_reset_function(vdev->pdev, PCI_RESET_ANY) :
+ -EINVAL;
} else if (cmd == VFIO_DEVICE_GET_PCI_HOT_RESET_INFO) {
struct vfio_pci_hot_reset_info hdr;
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index 115a36f6f403..0d66bac66211 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -831,7 +831,7 @@ static int vfio_exp_config_write(struct vfio_pci_device *vdev, int pos,
&cap);
if (!ret && (cap & PCI_EXP_DEVCAP_FLR))
- pci_try_reset_function(vdev->pdev);
+ pci_try_reset_function(vdev->pdev, PCI_RESET_ANY);
}
/*
@@ -910,7 +910,7 @@ static int vfio_af_config_write(struct vfio_pci_device *vdev, int pos,
&cap);
if (!ret && (cap & PCI_AF_CAP_FLR) && (cap & PCI_AF_CAP_TP))
- pci_try_reset_function(vdev->pdev);
+ pci_try_reset_function(vdev->pdev, PCI_RESET_ANY);
}
return count;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index fa852ebdf197..8652d7ac815c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1125,7 +1125,7 @@ int pcie_flr(struct pci_dev *dev);
int __pci_reset_function_locked(struct pci_dev *dev, u32 reset_type);
int pci_reset_function(struct pci_dev *dev, u32 reset_type);
int pci_reset_function_locked(struct pci_dev *dev, u32 reset_type);
-int pci_try_reset_function(struct pci_dev *dev);
+int pci_try_reset_function(struct pci_dev *dev, u32 reset_type);
int pci_probe_reset_slot(struct pci_slot *slot);
int pci_probe_reset_bus(struct pci_bus *bus);
int pci_reset_bus(struct pci_dev *dev);
--
2.18.0
next prev parent reply other threads:[~2018-09-08 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 4:16 [PATCH 1/4] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-09-08 4:16 ` [PATCH 2/4] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-09-08 4:16 ` Sinan Kaya [this message]
2018-09-08 4:16 ` [PATCH 4/4] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908041632.22252-3-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=eric.auger@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=linux-pci@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).