From: Alex Williamson <alex.williamson@redhat.com>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Peter Xu <peterx@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH v2 6/6] PCI: Expose reset type to users of pci_reset_bus()
Date: Fri, 14 Sep 2018 16:33:21 -0600 [thread overview]
Message-ID: <20180914163321.2abba9fa@t450s.home> (raw)
In-Reply-To: <20180914211808.2564-7-okaya@kernel.org>
On Fri, 14 Sep 2018 21:18:08 +0000
Sinan Kaya <okaya@kernel.org> wrote:
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index fe7ada997c51..754f08286bb1 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -1015,7 +1015,7 @@ static long vfio_pci_ioctl(void *device_data,
> &info, slot);
> if (!ret)
> /* User has access, do the reset */
> - ret = pci_reset_bus(vdev->pdev);
> + ret = pci_reset_bus(vdev->pdev, PCI_RESET_LINK);
This should have switched back the control we had prior to 811c5cb37df4
with something like:
ret = pci_reset_bus(vdev->pdev,
slot ? PCI_RESET_SLOT : PCI_RESET_BUS);
>
> hot_reset_release:
> for (i--; i >= 0; i--)
> @@ -1390,7 +1390,7 @@ static void vfio_pci_try_bus_reset(struct vfio_pci_device *vdev)
> }
>
> if (needs_reset)
> - ret = pci_reset_bus(vdev->pdev);
> + ret = pci_reset_bus(vdev->pdev, PCI_RESET_LINK);
Same here. Thanks,
Alex
next prev parent reply other threads:[~2018-09-15 3:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:18 [PATCH v2 0/6] PCI: Add reset type parameter to PCI reset functions Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 1/6] PCI: Expose reset_type to users of __pci_reset_function_locked() Sinan Kaya
2018-09-14 22:27 ` Alex Williamson
2018-09-14 22:57 ` Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 2/6] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-09-14 21:52 ` Srinivas Pandruvada
2018-09-14 23:20 ` Sinan Kaya
2018-09-15 1:48 ` Srinivas Pandruvada
2018-09-14 21:18 ` [PATCH v2 3/6] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 4/6] PCI: Expose reset type to users of pci_try_reset_function() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 5/6] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 6/6] PCI: Expose reset type to users of pci_reset_bus() Sinan Kaya
2018-09-14 22:33 ` Alex Williamson [this message]
2018-09-14 22:52 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914163321.2abba9fa@t450s.home \
--to=alex.williamson@redhat.com \
--cc=aik@ozlabs.ru \
--cc=bhelgaas@google.com \
--cc=gustavo@embeddedor.com \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).