From: Keith Busch <keith.busch@intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'
Date: Fri, 21 Sep 2018 08:13:34 -0600 [thread overview]
Message-ID: <20180921141333.GA1157@localhost.localdomain> (raw)
In-Reply-To: <201809211041.8FEIzMUy%fengguang.wu@intel.com>
On Fri, Sep 21, 2018 at 10:06:44AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head: 64ab39d38d17e5d53434d949681c3ff3ec0f79d3
> commit: d17964c0d81fc38c733fc5281436d2b262306a33 [15/24] PCI/DPC: Save and restore config state
> config: m68k-m5475evb_defconfig (attached as .config)
> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout d17964c0d81fc38c733fc5281436d2b262306a33
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=m68k
>
> All errors (new ones prefixed by >>):
>
> drivers/pci/bus.o: In function `pci_save_dpc_state':
> >> bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'
> drivers/pci/access.o:access.c:(.text+0x1114): first defined here
> drivers/pci/bus.o: In function `pci_restore_dpc_state':
> >> bus.c:(.text+0x35a): multiple definition of `pci_restore_dpc_state'
Appropriate fix to be sent:
---
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a244bd0c5ca7..eb3125decffe 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
void pci_save_dpc_state(struct pci_dev *dev);
void pci_restore_dpc_state(struct pci_dev *dev);
#else
-void pci_save_dpc_state(struct pci_dev *dev) {}
-void pci_restore_dpc_state(struct pci_dev *dev) {}
+static inline void pci_save_dpc_state(struct pci_dev *dev) {}
+static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
#endif
#ifdef CONFIG_PCI_ATS
--
prev parent reply other threads:[~2018-09-21 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 2:06 [pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state' kbuild test robot
2018-09-21 14:13 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921141333.GA1157@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox