[pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'

[pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 7304 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head:   64ab39d38d17e5d53434d949681c3ff3ec0f79d3
commit: d17964c0d81fc38c733fc5281436d2b262306a33 [15/24] PCI/DPC: Save and restore config state
config: m68k-m5475evb_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout d17964c0d81fc38c733fc5281436d2b262306a33
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   drivers/pci/bus.o: In function `pci_save_dpc_state':
>> bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/bus.o: In function `pci_restore_dpc_state':
>> bus.c:(.text+0x35a): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/probe.o: In function `pci_save_dpc_state':
   probe.c:(.text+0x756): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/probe.o: In function `pci_restore_dpc_state':
   probe.c:(.text+0x758): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/host-bridge.o: In function `pci_save_dpc_state':
   host-bridge.c:(.text+0x158): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/host-bridge.o: In function `pci_restore_dpc_state':
   host-bridge.c:(.text+0x15a): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/remove.o: In function `pci_save_dpc_state':
   remove.c:(.text+0x2f8): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/remove.o: In function `pci_restore_dpc_state':
   remove.c:(.text+0x2fa): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/pci.o: In function `pci_save_dpc_state':
   pci.c:(.text+0x2d8a): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/pci.o: In function `pci_restore_dpc_state':
   pci.c:(.text+0x2d8c): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/pci-driver.o: In function `pci_save_dpc_state':
   pci-driver.c:(.text+0x70c): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/pci-driver.o: In function `pci_restore_dpc_state':
   pci-driver.c:(.text+0x70e): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/search.o: In function `pci_save_dpc_state':
   search.c:(.text+0x462): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/search.o: In function `pci_restore_dpc_state':
   search.c:(.text+0x464): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/pci-sysfs.o: In function `pci_save_dpc_state':
   pci-sysfs.c:(.text+0x13ce): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/pci-sysfs.o: In function `pci_restore_dpc_state':
   pci-sysfs.c:(.text+0x13d0): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/rom.o: In function `pci_save_dpc_state':
   rom.c:(.text+0x3ee): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/rom.o: In function `pci_restore_dpc_state':
   rom.c:(.text+0x3f0): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/setup-res.o: In function `pci_save_dpc_state':
   setup-res.c:(.text+0x582): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/setup-res.o: In function `pci_restore_dpc_state':
   setup-res.c:(.text+0x584): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/vpd.o: In function `pci_save_dpc_state':
   vpd.c:(.text+0xb94): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/vpd.o: In function `pci_restore_dpc_state':
   vpd.c:(.text+0xb96): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/setup-bus.o: In function `pci_save_dpc_state':
   setup-bus.c:(.text+0xa64): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/setup-bus.o: In function `pci_restore_dpc_state':
   setup-bus.c:(.text+0xa66): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/setup-irq.o: In function `pci_save_dpc_state':
   setup-irq.c:(.text+0x0): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/setup-irq.o: In function `pci_restore_dpc_state':
   setup-irq.c:(.text+0x2): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/proc.o: In function `pci_save_dpc_state':
   proc.c:(.text+0x652): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/proc.o: In function `pci_restore_dpc_state':
   proc.c:(.text+0x654): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/slot.o: In function `pci_save_dpc_state':
   slot.c:(.text+0x5cc): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/slot.o: In function `pci_restore_dpc_state':
   slot.c:(.text+0x5ce): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here
   drivers/pci/quirks.o: In function `pci_save_dpc_state':
   quirks.c:(.text+0x3a9e): multiple definition of `pci_save_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1114): first defined here
   drivers/pci/quirks.o: In function `pci_restore_dpc_state':
   quirks.c:(.text+0x3aa0): multiple definition of `pci_restore_dpc_state'
   drivers/pci/access.o:access.c:(.text+0x1116): first defined here

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6371 bytes --]

Re: [pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'

[Keith Busch]

On Fri, Sep 21, 2018 at 10:06:44AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   64ab39d38d17e5d53434d949681c3ff3ec0f79d3
> commit: d17964c0d81fc38c733fc5281436d2b262306a33 [15/24] PCI/DPC: Save and restore config state
> config: m68k-m5475evb_defconfig (attached as .config)
> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d17964c0d81fc38c733fc5281436d2b262306a33
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=m68k 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/pci/bus.o: In function `pci_save_dpc_state':
> >> bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'
>    drivers/pci/access.o:access.c:(.text+0x1114): first defined here
>    drivers/pci/bus.o: In function `pci_restore_dpc_state':
> >> bus.c:(.text+0x35a): multiple definition of `pci_restore_dpc_state'

Appropriate fix to be sent:

---
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a244bd0c5ca7..eb3125decffe 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
 void pci_save_dpc_state(struct pci_dev *dev);
 void pci_restore_dpc_state(struct pci_dev *dev);
 #else
-void pci_save_dpc_state(struct pci_dev *dev) {}
-void pci_restore_dpc_state(struct pci_dev *dev) {}
+static inline void pci_save_dpc_state(struct pci_dev *dev) {}
+static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
 #endif
 
 #ifdef CONFIG_PCI_ATS
--