* [PATCH] PCI: Fix compile error with DPC disabled
@ 2018-09-21 14:22 Keith Busch
2018-09-21 16:57 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Keith Busch @ 2018-09-21 14:22 UTC (permalink / raw)
To: Linux PCI, Bjorn Helgaas; +Cc: Keith Busch
The alternate functions when CONFIG_PCIE_DPC is not defined need to be
static inline.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a244bd0c5ca7..eb3125decffe 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
void pci_save_dpc_state(struct pci_dev *dev);
void pci_restore_dpc_state(struct pci_dev *dev);
#else
-void pci_save_dpc_state(struct pci_dev *dev) {}
-void pci_restore_dpc_state(struct pci_dev *dev) {}
+static inline void pci_save_dpc_state(struct pci_dev *dev) {}
+static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
#endif
#ifdef CONFIG_PCI_ATS
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: Fix compile error with DPC disabled
2018-09-21 14:22 [PATCH] PCI: Fix compile error with DPC disabled Keith Busch
@ 2018-09-21 16:57 ` Bjorn Helgaas
2018-09-21 17:02 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2018-09-21 16:57 UTC (permalink / raw)
To: Keith Busch; +Cc: Linux PCI, Bjorn Helgaas
On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote:
> The alternate functions when CONFIG_PCIE_DPC is not defined need to be
> static inline.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
If you tell me which patch, I'll fold this into it so there's no bisection
hole.
> ---
> drivers/pci/pci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index a244bd0c5ca7..eb3125decffe 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
> void pci_save_dpc_state(struct pci_dev *dev);
> void pci_restore_dpc_state(struct pci_dev *dev);
> #else
> -void pci_save_dpc_state(struct pci_dev *dev) {}
> -void pci_restore_dpc_state(struct pci_dev *dev) {}
> +static inline void pci_save_dpc_state(struct pci_dev *dev) {}
> +static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
> #endif
>
> #ifdef CONFIG_PCI_ATS
> --
> 2.14.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: Fix compile error with DPC disabled
2018-09-21 16:57 ` Bjorn Helgaas
@ 2018-09-21 17:02 ` Keith Busch
2018-09-21 17:19 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Keith Busch @ 2018-09-21 17:02 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Linux PCI, Bjorn Helgaas
On Fri, Sep 21, 2018 at 11:57:29AM -0500, Bjorn Helgaas wrote:
> On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote:
> > The alternate functions when CONFIG_PCIE_DPC is not defined need to be
> > static inline.
> >
> > Signed-off-by: Keith Busch <keith.busch@intel.com>
>
> If you tell me which patch, I'll fold this into it so there's no bisection
> hole.
Thanks, I like that plan.
Fixes: d17964c0d81fc38c7 ("PCI/DPC: Save and restore config state")
https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/hotplug&id=d17964c0d81fc38c733fc5281436d2b262306a33
> > ---
> > drivers/pci/pci.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> > index a244bd0c5ca7..eb3125decffe 100644
> > --- a/drivers/pci/pci.h
> > +++ b/drivers/pci/pci.h
> > @@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
> > void pci_save_dpc_state(struct pci_dev *dev);
> > void pci_restore_dpc_state(struct pci_dev *dev);
> > #else
> > -void pci_save_dpc_state(struct pci_dev *dev) {}
> > -void pci_restore_dpc_state(struct pci_dev *dev) {}
> > +static inline void pci_save_dpc_state(struct pci_dev *dev) {}
> > +static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
> > #endif
> >
> > #ifdef CONFIG_PCI_ATS
> > --
> > 2.14.4
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: Fix compile error with DPC disabled
2018-09-21 17:02 ` Keith Busch
@ 2018-09-21 17:19 ` Bjorn Helgaas
2018-09-21 17:50 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2018-09-21 17:19 UTC (permalink / raw)
To: Keith Busch; +Cc: Linux PCI, Bjorn Helgaas
On Fri, Sep 21, 2018 at 11:02:34AM -0600, Keith Busch wrote:
> On Fri, Sep 21, 2018 at 11:57:29AM -0500, Bjorn Helgaas wrote:
> > On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote:
> > > The alternate functions when CONFIG_PCIE_DPC is not defined need to be
> > > static inline.
> > >
> > > Signed-off-by: Keith Busch <keith.busch@intel.com>
> >
> > If you tell me which patch, I'll fold this into it so there's no bisection
> > hole.
>
> Thanks, I like that plan.
>
> Fixes: d17964c0d81fc38c7 ("PCI/DPC: Save and restore config state")
>
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/hotplug&id=d17964c0d81fc38c733fc5281436d2b262306a33
Done, sorry to bother you, I could have figured that out in 10 seconds
myself from the 0-day robot email.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: Fix compile error with DPC disabled
2018-09-21 17:19 ` Bjorn Helgaas
@ 2018-09-21 17:50 ` Keith Busch
0 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2018-09-21 17:50 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Linux PCI, Bjorn Helgaas
On Fri, Sep 21, 2018 at 12:19:03PM -0500, Bjorn Helgaas wrote:
> On Fri, Sep 21, 2018 at 11:02:34AM -0600, Keith Busch wrote:
> > On Fri, Sep 21, 2018 at 11:57:29AM -0500, Bjorn Helgaas wrote:
> > > On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote:
> > > > The alternate functions when CONFIG_PCIE_DPC is not defined need to be
> > > > static inline.
> > > >
> > > > Signed-off-by: Keith Busch <keith.busch@intel.com>
> > >
> > > If you tell me which patch, I'll fold this into it so there's no bisection
> > > hole.
> >
> > Thanks, I like that plan.
> >
> > Fixes: d17964c0d81fc38c7 ("PCI/DPC: Save and restore config state")
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/hotplug&id=d17964c0d81fc38c733fc5281436d2b262306a33
>
> Done, sorry to bother you, I could have figured that out in 10 seconds
> myself from the 0-day robot email.
Oh, no problem at all. The breakage was my mistake, so my apologies. I
don't like getting caught by 0-day, but I'm happy it's there! :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-21 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 14:22 [PATCH] PCI: Fix compile error with DPC disabled Keith Busch
2018-09-21 16:57 ` Bjorn Helgaas
2018-09-21 17:02 ` Keith Busch
2018-09-21 17:19 ` Bjorn Helgaas
2018-09-21 17:50 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).