From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA1EC433F4 for ; Fri, 21 Sep 2018 17:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A349B21557 for ; Fri, 21 Sep 2018 17:48:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A349B21557 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391109AbeIUXid (ORCPT ); Fri, 21 Sep 2018 19:38:33 -0400 Received: from mga06.intel.com ([134.134.136.31]:40539 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbeIUXid (ORCPT ); Fri, 21 Sep 2018 19:38:33 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 10:48:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="92167090" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2018 10:48:35 -0700 Date: Fri, 21 Sep 2018 11:50:33 -0600 From: Keith Busch To: Bjorn Helgaas Cc: Linux PCI , Bjorn Helgaas Subject: Re: [PATCH] PCI: Fix compile error with DPC disabled Message-ID: <20180921175033.GA1731@localhost.localdomain> References: <20180921142210.1191-1-keith.busch@intel.com> <20180921165729.GK224714@bhelgaas-glaptop.roam.corp.google.com> <20180921170234.GA1496@localhost.localdomain> <20180921171903.GL224714@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180921171903.GL224714@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Sep 21, 2018 at 12:19:03PM -0500, Bjorn Helgaas wrote: > On Fri, Sep 21, 2018 at 11:02:34AM -0600, Keith Busch wrote: > > On Fri, Sep 21, 2018 at 11:57:29AM -0500, Bjorn Helgaas wrote: > > > On Fri, Sep 21, 2018 at 08:22:10AM -0600, Keith Busch wrote: > > > > The alternate functions when CONFIG_PCIE_DPC is not defined need to be > > > > static inline. > > > > > > > > Signed-off-by: Keith Busch > > > > > > If you tell me which patch, I'll fold this into it so there's no bisection > > > hole. > > > > Thanks, I like that plan. > > > > Fixes: d17964c0d81fc38c7 ("PCI/DPC: Save and restore config state") > > > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/hotplug&id=d17964c0d81fc38c733fc5281436d2b262306a33 > > Done, sorry to bother you, I could have figured that out in 10 seconds > myself from the 0-day robot email. Oh, no problem at all. The breakage was my mistake, so my apologies. I don't like getting caught by 0-day, but I'm happy it's there! :)