From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sinan Kaya <okaya@kernel.org>, Thomas Tai <thomas.tai@oracle.com>,
poza@codeaurora.org, Lukas Wunner <lukas@wunner.de>,
Christoph Hellwig <hch@lst.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 00/12] error handling and pciehp maintenance
Date: Thu, 4 Oct 2018 16:11:37 -0600 [thread overview]
Message-ID: <20181004221137.GB21834@localhost.localdomain> (raw)
In-Reply-To: <20181004214015.GK120535@bhelgaas-glaptop.roam.corp.google.com>
On Thu, Oct 04, 2018 at 04:40:15PM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 18, 2018 at 05:58:36PM -0600, Keith Busch wrote:
> > I ran into a lot of trouble testing error handling, and this series is
> > just trying to simplify some things. The first 4 fix up aer_inject, and
> > the rest are cleanup to make better use of kernel APIs.
> >
> > Keith Busch (12):
> > PCI: Set PCI bus accessors to noinline
> > PCI/AER: Covertly inject errors
> > PCI/AER: Reuse existing service device lookup
> > PCI/AER: Abstract AER interrupt handling
> > PCI/AER: Remove dead code
> > PCI/AER: Remove error source from aer struct
> > PCI/AER: Use kfifo for tracking events
> > PCI/AER: Use kfifo helper inserting locked elements
> > PCI/AER: Don't read upstream ports below fatal errors
> > PCI/AER: Use threaded IRQ for bottom half
> > PCI/AER: Use managed resource allocations
> > PCI/pciehp: Use device managed allocations
> >
> > drivers/pci/access.c | 4 +-
> > drivers/pci/hotplug/pciehp_core.c | 14 +-
> > drivers/pci/hotplug/pciehp_hpc.c | 48 ++----
> > drivers/pci/pcie/Kconfig | 2 +-
> > drivers/pci/pcie/aer.c | 219 ++++++---------------------
> > drivers/pci/pcie/aer_inject.c | 306 ++++++++++++++++++++------------------
> > drivers/pci/pcie/portdrv.h | 4 -
> > drivers/pci/pcie/portdrv_core.c | 1 +
> > 8 files changed, 227 insertions(+), 371 deletions(-)
>
> Thanks a lot for doing this! I applied these to pci/hotplug for
> v4.20, except for "PCI/AER: Don't read upstream ports below fatal
> errors", which seems to be already there via another posting, and
> "PCI/pciehp: Use device managed allocations", which needs a few
> tweaks.
Sounds good, and thanks for applying!
In case this went unnoticed, patch 2's aer_inject using ftrace hooks
to pci config accessors is really cool and fixes several kernel crashes
I encountered, but it may not work on every architecture. I'm not sure
how widely aer_inject is used, so maybe there are no concerns with the
DYNAMIC_FTRACE_WITH_REGS dependency, but I just want to reemphasize that
dependency in case there are valid objections.
next prev parent reply other threads:[~2018-10-04 22:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:58 [PATCH 00/12] error handling and pciehp maintenance Keith Busch
2018-09-18 23:58 ` [PATCH 01/12] PCI: Set PCI bus accessors to noinline Keith Busch
2018-09-18 23:58 ` [PATCH 02/12] PCI/AER: Covertly inject errors Keith Busch
2018-09-18 23:58 ` [PATCH 03/12] PCI/AER: Reuse existing service device lookup Keith Busch
2018-09-18 23:58 ` [PATCH 04/12] PCI/AER: Abstract AER interrupt handling Keith Busch
2018-09-18 23:58 ` [PATCH 05/12] PCI/AER: Remove dead code Keith Busch
2018-09-18 23:58 ` [PATCH 06/12] PCI/AER: Remove error source from aer struct Keith Busch
2018-09-18 23:58 ` [PATCH 07/12] PCI/AER: Use kfifo for tracking events Keith Busch
2018-09-18 23:58 ` [PATCH 08/12] PCI/AER: Use kfifo helper inserting locked elements Keith Busch
2018-09-18 23:58 ` [PATCH 09/12] PCI/AER: Don't read upstream ports below fatal errors Keith Busch
2018-09-18 23:58 ` [PATCH 10/12] PCI/AER: Use threaded IRQ for bottom half Keith Busch
2018-09-18 23:58 ` [PATCH 11/12] PCI/AER: Use managed resource allocations Keith Busch
2018-09-19 16:29 ` Sinan Kaya
2018-09-19 17:25 ` Keith Busch
2018-09-19 17:36 ` Sinan Kaya
2018-09-25 1:13 ` Benjamin Herrenschmidt
2018-09-25 14:17 ` Keith Busch
2018-09-18 23:58 ` [PATCH 12/12] PCI/pciehp: Use device managed allocations Keith Busch
2018-09-19 15:11 ` Sinan Kaya
2018-09-19 16:17 ` Keith Busch
2018-09-22 18:10 ` Lukas Wunner
2018-09-24 23:43 ` Bjorn Helgaas
2018-09-25 7:13 ` Lukas Wunner
2018-10-04 21:40 ` [PATCH 00/12] error handling and pciehp maintenance Bjorn Helgaas
2018-10-04 22:11 ` Keith Busch [this message]
2018-10-05 17:31 ` Bjorn Helgaas
2018-10-08 16:18 ` Keith Busch
2018-10-08 17:23 ` Bjorn Helgaas
2018-11-06 16:34 ` Lorenzo Pieralisi
2018-11-06 16:47 ` Keith Busch
2018-11-06 17:21 ` Lorenzo Pieralisi
2018-11-06 17:26 ` Keith Busch
2018-10-09 16:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004221137.GB21834@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).