From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB1EC0044C for ; Mon, 5 Nov 2018 21:57:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54A8F2084F for ; Mon, 5 Nov 2018 21:57:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54A8F2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387752AbeKFHSv (ORCPT ); Tue, 6 Nov 2018 02:18:51 -0500 Received: from mail.skyhub.de ([5.9.137.197]:44218 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387580AbeKFHSv (ORCPT ); Tue, 6 Nov 2018 02:18:51 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8hjGuZ0U_lVi; Mon, 5 Nov 2018 22:57:02 +0100 (CET) Received: from zn.tnic (p200300EC2BCD5300329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bcd:5300:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 85B0F1EC0291; Mon, 5 Nov 2018 22:57:02 +0100 (CET) Date: Mon, 5 Nov 2018 22:56:50 +0100 From: Borislav Petkov To: Bjorn Helgaas Cc: "Woods, Brian" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Clemens Ladisch , Jean Delvare , Guenter Roeck , Pu Wen , Jia Zhang , Takashi Iwai , Andy Whitcroft , Colin Ian King , Myron Stowe , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies Message-ID: <20181105215650.GG26868@zn.tnic> References: <20181102181055.130531-1-brian.woods@amd.com> <20181102181055.130531-3-brian.woods@amd.com> <20181102195925.GB160487@google.com> <20181102232948.GC26770@zn.tnic> <20181105214537.GA19420@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181105214537.GA19420@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Nov 05, 2018 at 03:45:37PM -0600, Bjorn Helgaas wrote: > amd_nb.c prevents us from achieving that goal. These patches don't > add new functionality; they merely describe minor topographical > differences in new hardware. We usually try to do that in a more > generic way, e.g., via an ACPI method, so the new platform can update > the ACPI method and use an old, already-qualified, already-shipped > kernel. > > I'm not strenuously objecting to these because this isn't a *huge* > deal, but I suspect it is a source of friction for distros that don't > want to update and requalify their software for every new platform. Err, how is this any different from adding distro support for a new CPU family? This is basically the same thing. When distros add support for new hardware, they have to backport patches for upstream. These PCI devices which are part of the CPU are part of that hardware enablement. So there's no way around doing that enablement. I don't think you can do "old distro, new hardware" stuff without *some* hw enablement. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.